ProPhotoRGB builtin transforms #2215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ProPhotoRGB (ROMM RGB) as a set of builtin transforms for color space conversions between ProPhotoRGB and ACES2065-1, including both native gamma 1.8 and sRGB gamma variants. Updates documentation: usage and available styles, registers the transforms in the registry. Adds comprehensive unit tests for registration, gamma curves, round-trip, and variant support. Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
doug-walker
requested changes
Oct 30, 2025
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
doug-walker
requested changes
Oct 31, 2025
There was a problem hiding this comment.
Thanks for the updates Vlad. Here are a few more requests, below.
Regarding the sRGB ProPhoto, it does not need a special LUT, so it is easy for people to add to configs, if they want. I will confirm at the next TSC meeting, but I don't think we should make this a built-in.
src/OpenColorIO/transforms/builtins/BuiltinTransformRegistry.cpp
Outdated
Show resolved
Hide resolved
tests/cpu/transforms/builtins/BuiltinTransformRegistry_tests.cpp
Outdated
Show resolved
Hide resolved
• ProPhotoRGB.cpp to remove unused linear-to-encoded LUT generation and updated the color space conversion to use build_conversion_matrix_to_XYZ_D65. • test cases in BuiltinTransform_tests.cpp and BuiltinTransformRegistry_tests.cpp. Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
|
@doug-walker i can't get what a problem with CLs. I have tested code builds in MSVC on windows and in clang-20 on Ubuntu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ProPhotoRGB (ROMM RGB) as a set of builtin transforms for color space conversions between ProPhotoRGB and ACES2065-1, including both native gamma 1.8 and sRGB gamma variants. Updates documentation: usage and available styles, registers the transforms in the registry. Adds comprehensive unit tests for registration, gamma curves, round-trip, and variant support.