Move out python packages installations from make_python and make_pyside6#1030
Merged
cedrik-fuoco-adsk merged 28 commits intoJan 8, 2026
Merged
Conversation
Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…ython outside of make_python.py Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
force-pushed
the
cleanup-make-python
branch
from
December 18, 2025 17:34
60c3721 to
322f330
Compare
Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>
…ecause certifi was moved outside of make_python.py Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…cakges like cpython, meson, ninja, etc from source Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
marked this pull request as ready for review
December 19, 2025 14:47
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
December 19, 2025 14:47
bernie-laberge
approved these changes
Dec 19, 2025
bernie-laberge
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @cedrik-fuoco-adsk !
rogernelson
approved these changes
Dec 19, 2025
rogernelson
left a comment
Contributor
There was a problem hiding this comment.
Great cleanup, I really only have one somewhat minor suggestion around the binary component package building,
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
rogernelson
approved these changes
Dec 19, 2025
eloisebrosseau
approved these changes
Dec 19, 2025
cedrik-fuoco-adsk
force-pushed
the
cleanup-make-python
branch
2 times, most recently
from
January 5, 2026 16:12
f3e1a3d to
1f2f811
Compare
Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
merged commit Jan 8, 2026
4245dd1
into
AcademySoftwareFoundation:main
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move out python packages installations from make_python and make_pyside6
Linked issues
n/a
Summarize your change.
Changes:
I changed pip install strategy from --no-binary :all: --only-binary pip,setuptools,wheel to --no-binary opentimelineio,numpy,PyOpenGL-accelerate,cryptography,pydantic,cffi.
Note: cffi was added because of Windows and the debug build.
Previously:
Forced all packages (except pip/setuptools/wheel) to build from source, including build tools (Cython, meson-python, ninja), pure Python packages (certifi, six, packaging, requests), and packages with native extensions
Now:
Only packages with C/C++/Rust extensions that need to link against our custom Python build are compiled from source. All other packages (build tools, pure Python libraries) use pre-built binary wheels
Rationale:
Build tools like Cython don't need to match our Python's ABI. They're just tools used during compilation. Pre-built wheels work fine and install much faster. Only runtime dependencies with native code that links to Python (like numpy's C extensions or cryptography's Rust/C code) need to be built against our specific Python build
Describe the reason for the change.
It was not clear why some package were installed in the
requirements.txt, or inmake_python.pyor at both places.I think it will be more robust like this and more clear.
Describe what you have tested and on which operating system.
MacOS + CI
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.