add rendering notes #1679
add rendering notes #1679
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
==========================================
- Coverage 85.99% 79.84% -6.16%
==========================================
Files 200 197 -3
Lines 20934 21792 +858
Branches 2459 4358 +1899
==========================================
- Hits 18002 17399 -603
+ Misses 2331 2232 -99
- Partials 601 2161 +1560
Flags with carried forward coverage won't be shown. Click here to find out more. see 132 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
What would also be really useful is the equivalent of the "project settings" in Final Cut Pro for establishing the output resolution, audio format, etc: Currently in tlRender I make a guess at the settings by using the video and audio from the first clip in the timeline. This works mostly OK but fails in some situations and also requires opening the media.
|
|
I spun the project settings suggestion @darbyjohnston made into #1683 - I know it'd been talked about before but we'd failed to capture it as an issue. Thanks for highlighting it again! |
Signed-off-by: Nick Porcino <[email protected]>
|
@reinecke @darbyjohnston Does my edit on compositing ring true? |
|
Looks good to me, thanks. For transparent clips that allow the background to show through, we assume the background color is black? |
Signed-off-by: Nick Porcino <[email protected]>
|
@darbyjohnston yes, I added a bit about zero values, and 100% values for alpha. Note that I specified zero, not black, because if we say "black" then it invites discussion about black levels and what we expect to happen for non-zero blacks. I also said 100% so that no one wonders if we mean "1", "1.0", or "255" or ... |
|
Thanks, I think the note about "zero" is good so we don't get into color issues as you mentioned. Why the 100% alpha? For viewers it is nice to preserve the alpha channels for checking renders, though that could also be achieved by viewing the individual elements instead of the final composite. |
|
This update looks really good to me. On the background color, I think 100% opaque zero color values is a good baseline to match most NLEs. That said, if an application wants to allow people to override that behavior, there’s nothing stopping them. |
|
If someone wants to go ahead and approve, we can merge. |
|
It looks like the DCO check is failing... |
|
right, if we accept changes in the online form, as we I did, the dco is not attached. heavy sigh. |
|
Does anyone know a trick for repairing that? If not, I'm inclined to just merge, as there are not enough hours in the day to recreate a PR and go through the whole rigamarole again |
|
I forced DCO pass and merged - thanks for updating the docs @meshula |
This PR adds notes on rendering since rendering behavior is unclear from the specification itself.