Replace (void*) with EXR_CONST_CAST in extract_attr_float_vector - #2593
Open
cary-ilm wants to merge 1 commit into
Open
Replace (void*) with EXR_CONST_CAST in extract_attr_float_vector#2593cary-ilm wants to merge 1 commit into
cary-ilm wants to merge 1 commit into
Conversation
The fix in AcademySoftwareFoundation#2582 obscured the const cast. Better to make it obvious that const is being cast away here, as it is in the `scratch->sequential_read` call a few lines before. This simply shuffles the bytes on the data just read into the const float* array on big-endian machines. Signed-off-by: Cary Phillips <seabeepea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #2582 obscured the const cast. Better to make it obvious that const is being cast away here, as it is in the
scratch->sequential_readcall a few lines before.There's no functionality change here, just a clearer way of specifying the cast.
The call in question simply shuffles the bytes on the data just read into the const float* array on big-endian machines, which is why the const cast is acceptable in the first place.