Add explicit implementations of TypedAttribute copy/move constructors - #2601
Open
cary-ilm wants to merge 2 commits into
Open
Add explicit implementations of TypedAttribute copy/move constructors#2601cary-ilm wants to merge 2 commits into
cary-ilm wants to merge 2 commits into
Conversation
TypedAttribute<T>'s copy/move constructor and assignment operator were declared `= default`. Under Clang on Windows (msys2 CLANG64), an explicit class-template instantiation (`template class TypedAttribute<int>;`, used to export the class from the DLL) does not emit out-of-line definitions for implicitly-defined special members, which leads to undefined symbols at link time. Assisted-by: GitHub Copilot CLI (model: Claude Sonnet 5) Signed-off-by: Cary Phillips <seabeepea@gmail.com>
meshula
approved these changes
Aug 21, 2026
meshula
left a comment
meshula
left a comment
Contributor
There was a problem hiding this comment.
Could we add a comment to help future us understand this is pattern is deliberate (without having to diff through history)? Something like -
Declare copy constructor, move, and assignment operators explicitly in order to force Clang on Windows to emit these members.
Signed-off-by: Cary Phillips <seabeepea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedAttribute's copy/move constructor and assignment operator were declared
= default. Under Clang on Windows (msys2 CLANG64), an explicit class-template instantiation (template class TypedAttribute<int>used to export the class from the DLL) does not emit out-of-line definitions for implicitly-defined special members, which leads to undefined symbols at link time.One more in a series of steps to get OpenEXR building properly on Windows clang.
Assisted-by: GitHub Copilot CLI (model: Claude Sonnet 5)