test: slim testIDT.cpp — spot-checks and fingerprints (#276) - #317
Open
VedantMadane wants to merge 1 commit into
Open
test: slim testIDT.cpp — spot-checks and fingerprints (#276)#317VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
…wareFoundation#276) Replace large embedded numeric tables with first/last (and mid) sample assertions for fixture loads, and FNV-1a fingerprints over little-endian doubles for transformation outputs (TI/XYZ/RGB and scaled illuminant). Preserves coverage while cutting thousands of hard-to-review literal lines. Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #276: slim
tests/testIDT.cppby removing redundant full-table literals.Before: ~5.6k lines / ~400KB
After: ~800 lines / ~32KB
Approach
OIIO_CHECK_EQUAL_THRESHvalues and assert a deterministic FNV-1a fingerprint over IEEE754 little-endian doubles for the full result.Test plan
testIDT(or full unit test suite) on CI linux/mac/windowsCloses #276