-
Notifications
You must be signed in to change notification settings - Fork 100
#98: Open Image IO Library / Reader #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#98: Open Image IO Library / Reader #171
Conversation
…f the build directory. Signed-off-by: Philippe Leprince <[email protected]>
Configure proper rpath settings for macOS app bundles to ensure dynamic libraries are correctly located at runtime. This includes setting INSTALL_RPATH and using install_name_tool to fix library paths in both the app bundle and executable. Added a new CMake script to automatically fix library paths after build and updated macdeployqt integration to handle rpath changes for libglobal.dylib. Signed-off-by: Philippe Leprince <[email protected]>
…e wheel with shift modifier. - When using a mouse on MacOS laptops with trackpads, wheel.angleDelta.y always returns 0 when SHIFT is pressed, but the x component changes instead. Use x if y is 0 to enable zooming. - Note that the scrolling trackpad gesture changes the y value as expected. This change handles both cases. - Also limit scaleY between 0.6 and 2.0 to prevent unusable values. Signed-off-by: Philippe Leprince <[email protected]>
…ylib-rpath-in-mac-os-app-bundles 146: Resolve dylib rpath issues in MacOS app bundles
…mySoftwareFoundation#148-macos-timeline-sfift-scrollwheel-fix 148: fix timeline zoom behavior on MacOS laptops
Signed-off-by: Tony Dorfmeister <[email protected]>
…x/annotation-tools Fixes Drawing Annotation Tools
8e71ee7 to
fa826de
Compare
|
There is a limitation in my current implementation. This limitation could be addressed in future iterations if use cases requiring mixed-format channels are identified. |
95a3f56 to
bcf1d4c
Compare
Signed-off-by: Thomas Manceau <[email protected]>
bcf1d4c to
89d26ca
Compare
Signed-off-by: Thomas Manceau <[email protected]>
89d26ca to
3ec87e3
Compare
|
Thanks so much for this! I will test this on Mac & Windows. |
| }, | ||
| { | ||
| "name": "openimageio", | ||
| "version": "2.5.19.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VCPKG doesn't seem to have a port for this version. I changed this to "2.5.16.0#1" which looks like the latest version (v2) available. It then builds and runs ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on a CMake superbuild script.
This script downloads dependencies from GitHub, archives, or other sources, builds them for the target platform, and links them into xstudio.
It could be a great addition for anyone who doesn’t use vcpkg, or when vcpkg doesn’t provide the required version.
4b886d5 to
8cde0df
Compare
Add OpenImageIO Media Reader Plugin for xStudio
linked ticket: #98
Summarize your change
This PR adds a new media reader plugin using OpenImageIO (OIIO).
Describe the reason for the change
xStudio currently supports only video, OpenEXR, and PPM image formats, and lacks support for common formats such as PNG, JPEG, and TIFF.
By integrating OpenImageIO, we can now read all image formats supported by OIIO without requiring specific implementations for each one.
These changes add support for:
Describe what you have tested and on which operating system
Testing Environment:
Tests done manually:
Add a list of changes, and note any that might need special attention during the review
src/plugin/media_reader/openimageio/src/openimageio.cpp:src/plugin/media_reader/openimageio/src/openimageio.hppsrc/plugin/media_reader/openimageio/CMakeLists.txtsrc/plugin/media_reader/openimageio/test/openimageio_test.cppvcpkg.json-- I'm not using vcpkg to build xstudio, need special attention there