Skip to content

Fix migrations #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zjb0807 merged 2 commits into from
Nov 10, 2025
Merged

Fix migrations #2942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ea701
fix migrations
zjb0807 Nov 10, 2025
9e88b12
fix
zjb0807 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions runtime/acala/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,13 +1999,25 @@ pub type Executive = frame_executive::Executive<
Migrations,
>;

parameter_types! {
pub const XTokensPallet: &'static str = "XTokens";
pub const MigrationStatus: &'static str = "MigrationStatus";
pub struct RemoveXTokensMigrationStatus<T>(frame_support::pallet_prelude::PhantomData<T>);

impl<T: frame_system::Config> frame_support::traits::OnRuntimeUpgrade for RemoveXTokensMigrationStatus<T> {
fn on_runtime_upgrade() -> Weight {
let key = frame_support::storage::storage_prefix(b"XTokens", b"MigrationStatus");
log::info!(
"key: {:?}, exists: {:?}",
key,
frame_support::storage::unhashed::exists(&key)
);

frame_support::storage::unhashed::kill(&key);

T::DbWeight::get().writes(1)
}
}

#[allow(unused_parens)]
type Migrations = (frame_support::migrations::RemoveStorage<XTokensPallet, MigrationStatus, RocksDbWeight>,);
type Migrations = (RemoveXTokensMigrationStatus<Runtime>);

#[cfg(feature = "runtime-benchmarks")]
#[macro_use]
Expand Down
20 changes: 16 additions & 4 deletions runtime/karura/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,13 +2006,25 @@ pub type Executive = frame_executive::Executive<
Migrations,
>;

parameter_types! {
pub const XTokensPallet: &'static str = "XTokens";
pub const MigrationStatus: &'static str = "MigrationStatus";
pub struct RemoveXTokensMigrationStatus<T>(frame_support::pallet_prelude::PhantomData<T>);

impl<T: frame_system::Config> frame_support::traits::OnRuntimeUpgrade for RemoveXTokensMigrationStatus<T> {
fn on_runtime_upgrade() -> Weight {
let key = frame_support::storage::storage_prefix(b"XTokens", b"MigrationStatus");
log::info!(
"key: {:?}, exists: {:?}",
key,
frame_support::storage::unhashed::exists(&key)
);

frame_support::storage::unhashed::kill(&key);

T::DbWeight::get().writes(1)
}
}

#[allow(unused_parens)]
type Migrations = (frame_support::migrations::RemoveStorage<XTokensPallet, MigrationStatus, RocksDbWeight>,);
type Migrations = (RemoveXTokensMigrationStatus<Runtime>);

#[cfg(feature = "runtime-benchmarks")]
#[macro_use]
Expand Down