Skip to content

Conversation

@yuliialikhyt
Copy link
Collaborator

@yuliialikhyt yuliialikhyt commented Sep 29, 2025

PR details

Added new type triggeredSendSummary

What changes did you make? (Give an overview)

Added tests, metadata type files for the new type

I will update the documentation once the PR is approved or merged into develop.

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@yuliialikhyt yuliialikhyt linked an issue Sep 29, 2025 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

Coverage Report

Commit:6b5cc21
Base: develop@894b204

Type Base This PR
Total Statements Coverage  70.74%  70.77%  (+0.03%)
Total Branches Coverage  70.82%  70.79%  (-0.03%)
Total Functions Coverage  83.35%  83.42%  (+0.07%)
Total Lines Coverage  70.74%  70.77%  (+0.03%)
Details (changed files):
File Statements Branches Functions Lines
lib/MetadataTypeDefinitions.js  100%  100%  100%  100%
lib/MetadataTypeInfo.js  100%  100%  100%  100%
lib/metadataTypes/TriggeredSendSummary.js  80.39%  57.14%  100%  80.39%

@yuliialikhyt yuliialikhyt self-assigned this Sep 29, 2025
@yuliialikhyt yuliialikhyt marked this pull request as ready for review September 30, 2025 19:19
@JoernBerkefeld JoernBerkefeld changed the base branch from main to develop October 15, 2025 09:53
@JoernBerkefeld JoernBerkefeld added this to the 8.2.0 milestone Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new metadata type called triggeredSendSummary to retrieve summary statistics for triggered sends. This allows users to access metrics like sent count, bounces, opens, clicks, and other engagement data for triggered send campaigns.

  • Added complete implementation for the triggeredSendSummary metadata type
  • Created comprehensive test coverage with mock data and expected results
  • Integrated the new type into the metadata type registry and definitions

Reviewed Changes

Copilot reviewed 7 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/type.triggeredSendSummary.test.js Test suite for the new metadata type with retrieve functionality
test/resources/9999999/triggeredSendSummary/retrieve-response.xml Mock SOAP response for testing
test/resources/9999999/triggeredSendSummary/get-expected.json Expected JSON output for test validation
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js Field definitions and metadata configuration
lib/metadataTypes/TriggeredSendSummary.js Core implementation with retrieve and post-processing logic
lib/MetadataTypeInfo.js Registration of the new metadata type
lib/MetadataTypeDefinitions.js Registration of the type definition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JoernBerkefeld JoernBerkefeld changed the title Feature/2371 feature add new metadata type triggeredsendsummary Feature/2371 feature add new metadata type triggeredSendSummary Oct 15, 2025
@yuliialikhyt
Copy link
Collaborator Author

@JoernBerkefeld Thank you :) I agree with your comments. I think I addressed them all.

Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will probably have to re-do the test-data

@yuliialikhyt
Copy link
Collaborator Author

you will probably have to re-do the test-data

Had to update the number of expected calls. Didn't update the test data. Doesn't seem like the retrieved fields changed.

@JoernBerkefeld
Copy link
Contributor

good job @yuliialikhyt
Thank you for your contribution once more :)

@JoernBerkefeld JoernBerkefeld merged commit 7b58c74 into develop Oct 24, 2025
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/2371-feature-add-new-metadata-type-triggeredsendsummary branch October 24, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/triggeredSend COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add new metadata type TriggeredSendSummary

3 participants