-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/2371 feature add new metadata type triggeredSendSummary #2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2371 feature add new metadata type triggeredSendSummary #2372
Conversation
…riggeredsendsummary
Coverage ReportCommit:6b5cc21Base: develop@894b204 Details (changed files):
|
…dsummary' of https://github.com/Accenture/sfmc-devtools into feature/2371-feature-add-new-metadata-type-triggeredsendsummary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new metadata type called triggeredSendSummary to retrieve summary statistics for triggered sends. This allows users to access metrics like sent count, bounces, opens, clicks, and other engagement data for triggered send campaigns.
- Added complete implementation for the
triggeredSendSummarymetadata type - Created comprehensive test coverage with mock data and expected results
- Integrated the new type into the metadata type registry and definitions
Reviewed Changes
Copilot reviewed 7 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/type.triggeredSendSummary.test.js | Test suite for the new metadata type with retrieve functionality |
| test/resources/9999999/triggeredSendSummary/retrieve-response.xml | Mock SOAP response for testing |
| test/resources/9999999/triggeredSendSummary/get-expected.json | Expected JSON output for test validation |
| lib/metadataTypes/definitions/TriggeredSendSummary.definition.js | Field definitions and metadata configuration |
| lib/metadataTypes/TriggeredSendSummary.js | Core implementation with retrieve and post-processing logic |
| lib/MetadataTypeInfo.js | Registration of the new metadata type |
| lib/MetadataTypeDefinitions.js | Registration of the type definition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
…e-triggeredsendsummary
…dsummary' of https://github.com/Accenture/sfmc-devtools into feature/2371-feature-add-new-metadata-type-triggeredsendsummary
|
@JoernBerkefeld Thank you :) I agree with your comments. I think I addressed them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will probably have to re-do the test-data
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
lib/metadataTypes/definitions/TriggeredSendSummary.definition.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jörn Berkefeld <[email protected]>
Co-authored-by: Jörn Berkefeld <[email protected]>
Had to update the number of expected calls. Didn't update the test data. Doesn't seem like the retrieved fields changed. |
|
good job @yuliialikhyt |
PR details
Added new type triggeredSendSummary
What changes did you make? (Give an overview)
Added tests, metadata type files for the new type
I will update the documentation once the PR is approved or merged into develop.
Further details (optional)
...
Checklist