-
Notifications
You must be signed in to change notification settings - Fork 325
70 fix sales invoice model #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joyceh14
wants to merge
371
commits into
AccountGo:main
Choose a base branch
from
medhatelmasry:70-fix-sales-invoice-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
70 fix sales invoice model #203
joyceh14
wants to merge
371
commits into
AccountGo:main
from
medhatelmasry:70-fix-sales-invoice-model
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deed-books [Fix issue] Change app name to Good Deed Books
…age appearing nothing.
[Fix issue] Financials >> Taxes : There are clickable columns on this page but appear to do nothing.
…y/GoodBooks into 11-financials-taxes
[Fix issue] Financials >> Taxes : There are clickable columns on this page but appear to do nothing.
…egrating mvc app and blazor.
…y/GoodBooks into 11-financials-taxes
[Fix issue] Financials >> Taxes : Redirection to base_route/#settings
…accounts [Feature issue] Exand & collapse chart of accounts
…dhatelmasry/GoodBooks into allow-accounts-to-be-editable
aspire workload in yml files
changed 8.0 to 9.0 on dotnet publish line in api yml
…re-Solution Got Aspire working with SQL Server in an automated fashion with a wor…
51 fix allocations
Allow accounts to be editable
updated all packages to latest and upgraded aspire to .net 9.0
…voice show under salse receipt to allocate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue where the "Posted" checkbox value wasn’t being saved properly has now been resolved.


The "Posted" state was being determined based on whether the GeneralLedgerHeaderId field in the SalesInvoice entity was null or not from existing logic. Although the checkbox value was selected in the UI, it wasn't being properly tied to the logic that assigns the GeneralLedgerHeaderId, which caused the invoice to remain "unposted" in the backend.
Now when the "Posted" checkbox is selected, it triggers the logic to set the GeneralLedgerHeaderId, making the invoice marked as "Posted" in the system. As a result, these invoices will now appear correctly when selecting Sales Receipts for allocation.