Deprecate InvalidEmailAddressError
#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balvig
force-pushed
the
jb/deprecate-invalidemailaddresserror
branch
2 times, most recently
from
a28e601 to
e79d23e
Compare
balvig
force-pushed
the
jb/deprecate-invalidemailaddresserror
branch
from
e79d23e to
274c6e6
Compare
balvig
force-pushed
the
jb/deprecate-invalidemailaddresserror
branch
from
2e3196f to
55a268f
Compare
tomek-ac
reviewed
Jan 17, 2023
There was a problem hiding this comment.
@balvig could we somehow let the users know that this class shouldn't be referenced any more? Maybe something like: https://stackoverflow.com/a/29696289
@tomek-ac that's a good idea. 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
InvalidEmailAddressErrortoInvalidEmailRequestErrorInvalidEmailAddressError#120Why
This addresses some confusion around this error that can occur for a number of reasons, and not just invalid email addresses, bringing it more in sync with the API definition
How
For now this is just a straight rename with an alias provided for backwards compatibility.
@tomazy let me know if there's anything you had in mind for this! 🙏