forked from AdaGold/Bipartition-Graph
-
Notifications
You must be signed in to change notification settings - Fork 16
Erica #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
norrise120
wants to merge
1
commit into
Ada-C11:master
Choose a base branch
from
norrise120:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Erica #3
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,41 @@ | ||
# I tried my best! All the test pass except for number 4. I know that the problem | ||
# is that I should be moving through the dislikes as they appear instead of just | ||
# linearly. However, for whatever when I tried using a stack and popping off the | ||
# values, it didnt alter my stack--meaning the stack grew in length and I was | ||
# trapped in a loop. | ||
|
||
def possible_bipartition(dislikes) | ||
raise NotImplementedError, "possible_bipartition isn't implemented yet" | ||
end | ||
outer_length = dislikes.length | ||
return true if outer_length <= 2 | ||
|
||
groupA = {} | ||
groupB = {} | ||
|
||
outer_length.times do |x| | ||
if dislikes[x].length == 0 | ||
next | ||
end | ||
|
||
other = 'B' | ||
if groupA[x] || groupB[x] | ||
other = groupA[x] ? 'B' : 'A' | ||
elsif !groupA[x] && !groupB[x] | ||
groupA[x] = 1 | ||
else | ||
groupB[x] = 1 | ||
other = 'A' | ||
end | ||
|
||
dislikes[x].each do |i| | ||
if other == 'B' | ||
return false if groupA[i] | ||
groupB[i] = 1 | ||
elsif other == 'A' | ||
return false if groupB[i] | ||
groupA[i] = 1 | ||
end | ||
end | ||
end | ||
|
||
return true | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are going to need a stack or queue to traverse the graph so that you can keep consistent that you going toggling between the two "colors" or groups while on a path.
Your code here isn't traversing a graph, but instead iterating through the list of nodes. Take a look at either my breadth-first-search or depth-first-search solutions.