Ports - Heather & Laneia #12

laneia · 2019-02-22T23:09:18Z

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the components that make up a method?	Method signature, method body, return statement, invocation.
What are the advantages of using git when collaboratively working on one code base?	Allows all collaborators to work on the same code and track changes quickly and easily.
What kind of relationship did you and your pair have with the unit tests?	They were helpful.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	Many, we used select, may_by, map, etc. They were useful for iterating through the stored data and returning desired elements.
What was one method you and your pair used to debug code?	Used awesome print (with assistance), printing local variables/outputs to test loops for correct output.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	1. did not finalize changes until both people understood the code 2. need to be cognizant of finding balance between individual research versus individual coding outside of pair time

…5 function

tildeee · 2019-03-04T06:40:55Z

Adagrams

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	x
Both teammates contributed to the codebase	x
Small commits with meaningful commit messages	x, in general, would be looking for commit messages that described the changes made, not "wave 2" etc
Code Requirements
`draw_letters` method	x
Uses appropriate data structure to store the letter distribution	x
All tests for `draw_letters` pass	x
`uses_available_letters?` method	x
All tests for `uses_available_letters?` pass	x
`score_word` method	x
Uses appropriate data structure to store the letter scores	x
All tests for `score_word` pass	x
`highest_score_from` method	x
Appropriately handles edge cases for tie-breaking logic	x
All tests for `highest_score_from` pass	x
Overall

Hi Heather and Laneia! Great work on this project!

In general, I think you all really rocked this project in terms of finding elegant, beautiful, logical, clean, concise solutions. They are very aligned with thinking like a programmer: being comfortable transforming, filtering, and finding data in ways that work for you.

I think sometimes this sacrifices readability, so I put a few comments where I thought that might be true. However, I won't tell you two to STOP writing code like this, because it's beautiful, but please keep readability in mind in the future ;)

Also, great work on the optional wave!

Again, great work overall.

tildeee · 2019-03-04T06:41:13Z

lib/adagrams.rb

+
+def draw_letters
+  avail_letters = %w[A A A A A A A A A B B C C D D D D E E E E E E E E E E E E F F G G G H H I I I I I I I I I J K L L L L M M N N N N N N O O O O O O O O P P Q R R R R R R S S S S T T T T T T U U U U V V W W X Y Y Z]
+  avail_letters.sample(10)


Yes! I love this syntax! This implementation is so short! :) Fantastic.

tildeee · 2019-03-04T06:41:20Z

lib/adagrams.rb

+
+def draw_letters
+  avail_letters = %w[A A A A A A A A A B B C C D D D D E E E E E E E E E E E E F F G G G H H I I I I I I I I I J K L L L L M M N N N N N N O O O O O O O O P P Q R R R R R R S S S S T T T T T T U U U U V V W W X Y Y Z]
+  avail_letters.sample(10)


In general, your code takes advantage of Ruby's implicit return statements, but if you ever felt like going back to explicit return statements, I wouldn't be mad...

tildeee · 2019-03-04T06:41:38Z

lib/adagrams.rb

+end
+
+sample = draw_letters
+# print sample


Since this code will not be used when running tests, feel free to delete these lines before project submission

tildeee · 2019-03-04T06:42:35Z

lib/adagrams.rb

+    else
+      false
+    end
+  end


VERY interesting and good job of implementing your own .all? logic! I love it! In general, I think that understanding the implicit return of this method might be confusing, so I might recommend rewriting this code to be something like, and take advantage of variables storing what the .all? block turns into, and using the explicit return

I have an example of maybe what I would do:

is_valid = input.each_char.all? do |char| if letters_in_hand.include?(char) letters_in_hand.delete_at(letters_in_hand.index(char)) true else false end end return is_valid

tildeee · 2019-03-04T06:43:08Z

lib/adagrams.rb

+  score_chart.each_with_index do |letter_bank, letter_value|
+    word.each_char do |char|
+      if letter_bank.include?(char)
+        score << (letter_value + 1)


Ha! Interesting relationship between the index of the letter_bank inside of score_chart and its point value. Because this relationship isn't very trustworthy, I might suggest using a different data structure with a more obvious relationship between letter and point value, but I applaud this Sherlock Holmes sleuthing ;)

tildeee · 2019-03-04T06:43:55Z

lib/adagrams.rb

+    score << 8
+  end
+
+  return score.sum


I think it's really fascinating that you all did an array of scores and then summed it in the end! I think most people would have opted to just add them, but I think this is also valid and interesting and cool and is very compatible with thinking like a programmer :D

tildeee · 2019-03-04T06:44:11Z

lib/adagrams.rb

+
+  high_score = scored_words.max_by { |point|
+    point[:each_score]
+  }[:each_score]


Fantastic use of max_by (this is one of my favorite solutions to this part of the project!)

tildeee · 2019-03-04T06:44:33Z

lib/adagrams.rb

+    semi_finalist[:each_score] == high_score
+  }.map { |semi_finalist|
+    semi_finalist[:each_word]
+  }


I think that using select and map are the right ways to go about this. However, you're starting to chain a lot of methods together, which is valid, but leads to unreadable code. Breaking up these two method calls (select and map) into two different lines doesn't detract from your elegant code style, in my opinion!

tildeee · 2019-03-04T06:45:05Z

lib/adagrams.rb

+  }
+
+  if highest_scored_words.length == 1
+    return ultimate_winner = {word: highest_scored_words[0], score: high_score}


Since the return statement ends the method, you're probably okay with skipping the variable assignment: return {word: highest_scored_words[0], score: high_score}

tildeee · 2019-03-04T06:45:34Z

lib/adagrams.rb

+  if highest_scored_words.length == 1
+    return ultimate_winner = {word: highest_scored_words[0], score: high_score}
+  elsif highest_scored_words.length > 1
+    winner = highest_scored_words.find { |ten| ten.length == 10 }


Nice! This works with knowing that .find will find the FIRST instance of true, which meets the requirements. ten is probably not my favorite variable name though.

tildeee · 2019-03-04T06:45:45Z

lib/adagrams.rb

+end
+
+def is_in_english_dict?(user_input_word)
+  require "csv"


You'll want to put all require statements at the top of the file no matter what!

tildeee · 2019-03-04T06:45:54Z

lib/adagrams.rb

+    dictionary_array << row
+  end
+  dictionary_array.flatten!
+  return dictionary_array.include?(user_input_word) ? true : false


Consider why this is the same thing as above: return dictionary_array.include?(user_input_word)

tildeee · 2019-03-04T06:46:00Z

lib/adagrams.rb

+  end
+  dictionary_array.flatten!
+  return dictionary_array.include?(user_input_word) ? true : false
+end


Nice work on this optional! :D ... Where are the tests to verify that it works? ;)

laneia added 3 commits February 22, 2019 13:50

committing waves 1, 2, & 3 (such small changes

cd1b278

Added wave 4

6aeec8c

Merge branch 'master' of https://github.com/laneia/adagrams

060e803

laneia changed the title ~~Heather & Laneia - Ports~~ Ports -Heather & Laneia Feb 22, 2019

laneia changed the title ~~Ports -Heather & Laneia~~ Ports - Heather & Laneia Feb 22, 2019

clone letters_in_hand in method uses_available_letters? to make wave …

2efbe21

…5 function

tildeee reviewed Mar 4, 2019

View reviewed changes

Uh oh!

Ports - Heather & Laneia #12

Are you sure you want to change the base?

Ports - Heather & Laneia #12

Uh oh!

Conversation

laneia commented Feb 22, 2019

Adagrams

Comprehension Questions

Uh oh!

tildeee commented Mar 4, 2019

Adagrams

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants