Skip to content

Conversation

@goblineer
Copy link

@goblineer goblineer commented Feb 22, 2019

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? There's a method signature (which may or may not contain method arguments) and a method body.
What are the advantages of using git when collaboratively working on one code base? Git tracks changes so anyone on the team can push new updates to the master repo and other folks can pull those changes to their own local machines. In short, it's version control. There is also a running log of every change so the master can always be rolled back to a previous version.
What kind of relationship did you and your pair have with the unit tests? This project gave us experience with both sides of the coin, so to speak/type. On our second day of pair work, we didn't run our tests as often as we should have, which resulted in a lot of lost time. After that, we understood the value of frequently testing small changes to iteratively improve our code based on the feedback from the automated tests.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? Throughout our code, there are no cases where we needed to iterate over arrays or hashes with an Enumerable method, but we did use .include to iterate over a string used as a key in our hash.
What was one method you and your pair used to debug code? We used dummy data to test our work and ran the provided game programs for each wave in order to see how our methods would perform. Between that and rake, we were able to pinpoint where in our code any errors were occurring and address them in a targeted way.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We talked about how our pair work changed dramatically as we adjusted to one another's needs and styles. As a team, we had initially agreed to switch roles every 20 minutes by using a timer and we both noticed how much better we felt on the final day when we abandoned that particular convention. Even though we had placed the constraint on ourselves with the best intentions, it turned out that it was wrong for our dynamic. Another mutual theme of our feedback was that communication style was only half the battle; our coding processes were very different! Ultimately, this pairing resulted in valuable feedback and perspective for both of us as well as some code that we were excited to turn in.

@CheezItMan
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Check, I'm glad your teamwork improved over the duration of the project.
Both teammates contributed to the codebase Check
Small commits with meaningful commit messages Your first few commits were enormous. Try to add one feature, like score and then commit that working method. Also make commit messages that describe the functionality you added instead of listing a wave. Otherwise well done.
Code Requirements
draw_letters method Check
Uses appropriate data structure to store the letter distribution Check
All tests for draw_letters pass Check
uses_available_letters? method Check
All tests for uses_available_letters? pass Check
score_word method Check
Uses appropriate data structure to store the letter scores Check
All tests for score_word pass Check
highest_score_from method Check
Appropriately handles edge cases for tie-breaking logic Check
All tests for highest_score_from pass Check
Overall Well done, you hit all the learning goals for the project. Nice work!

@@ -1,0 +1,75 @@
# draws letters into hand
def draw_letters
letter_distribution =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice data structure!

def uses_available_letters?(input, letters_in_hand)
word_array = []
input.each_char { |letter| word_array << letter }
return word_array & letters_in_hand == word_array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slick!


# scores word guessed and returns word score
def score_word(word)
letter_value =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

best_word = word
end
end
highest_score.store(:word, best_word)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just do highest_score[:word] = best_word?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants