-
Notifications
You must be signed in to change notification settings - Fork 40
KS #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
KS #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for turning in this PR Kate. Both methods work well are are efficient. Do take a look at my comments and consider adding the space/time complexities as well. Otherwise outstanding work.
# Time Complexity: ? | ||
# Space Complexity: ? | ||
|
||
def grouped_anagrams(strings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Space & Time Complexity?
deltas[max].each do |num| | ||
solution << num | ||
remains -= 1 | ||
break if remains == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this break since your while loop runs while remains > 0
break if remains == 0 | ||
end | ||
end | ||
max -= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation?
# in the case of a tie it will select the first occuring element. | ||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions