Skip to content

Conversation

MyriamWD
Copy link

React Timeline

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain what purpose a component serves in React?
How does adding dynamic content to a web page in React compare to jQuery?
How did you use props in this project?
Do you have any recommendations on how we could improve this project for the next cohort?

Copy link

@qqdipps qqdipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! lgtm

// Customize the code below
const dataArray = timelineData.events
const varHoldsTimeEvents = Timeline(dataArray);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting! Is this creating a <Timeline events={dataArray} /> ?


const varHoldsData = props.map((user, index) => {
return (<TimelineEvent key= {index} name={user.person} status={user.status} timeStamp={user.timeStamp}/>)
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this key = {index} prop get used in TimelineEvent?

<p className="event-status">{props.status}</p>
<Timestamp time={props.timeStamp}/>
</section>
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! nice JSX!

return (
<section className="timeline">
{varHoldsData}
</section>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varHoldsData I keep having to look at where this is declared to remember what data it holds.

</header>
<main className="App-main">
{varHoldsTimeEvents}
</main>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this variable name varHoldsTimeEvents, helps me remember that its prob a grouping of timeline events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants