Ports - Myriam #18
Open
Ports - Myriam #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqdipps
reviewed
Jun 11, 2019
| // Customize the code below | ||
| const dataArray = timelineData.events | ||
| const varHoldsTimeEvents = Timeline(dataArray); | ||
|
|
There was a problem hiding this comment.
this is interesting! Is this creating a <Timeline events={dataArray} /> ?
|
|
||
| const varHoldsData = props.map((user, index) => { | ||
| return (<TimelineEvent key= {index} name={user.person} status={user.status} timeStamp={user.timeStamp}/>) | ||
| }); |
There was a problem hiding this comment.
Does this key = {index} prop get used in TimelineEvent?
| <p className="event-status">{props.status}</p> | ||
| <Timestamp time={props.timeStamp}/> | ||
| </section> | ||
| ) |
| return ( | ||
| <section className="timeline"> | ||
| {varHoldsData} | ||
| </section> |
There was a problem hiding this comment.
varHoldsData I keep having to look at where this is declared to remember what data it holds.
| </header> | ||
| <main className="App-main"> | ||
| {varHoldsTimeEvents} | ||
| </main> |
There was a problem hiding this comment.
I like this variable name varHoldsTimeEvents, helps me remember that its prob a grouping of timeline events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions