-
Notifications
You must be signed in to change notification settings - Fork 44
Ports - Myriam #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ports - Myriam #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! lgtm
// Customize the code below | ||
const dataArray = timelineData.events | ||
const varHoldsTimeEvents = Timeline(dataArray); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is interesting! Is this creating a <Timeline events={dataArray} />
?
|
||
const varHoldsData = props.map((user, index) => { | ||
return (<TimelineEvent key= {index} name={user.person} status={user.status} timeStamp={user.timeStamp}/>) | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this key = {index}
prop get used in TimelineEvent?
<p className="event-status">{props.status}</p> | ||
<Timestamp time={props.timeStamp}/> | ||
</section> | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! nice JSX!
return ( | ||
<section className="timeline"> | ||
{varHoldsData} | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
varHoldsData
I keep having to look at where this is declared to remember what data it holds.
</header> | ||
<main className="App-main"> | ||
{varHoldsTimeEvents} | ||
</main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this variable name varHoldsTimeEvents
, helps me remember that its prob a grouping of timeline events.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions