Ports- Ngoc-Myriam #17

MyriamWD · 2019-04-19T23:52:38Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	passenger has many trips, driver has many trips, trips belong to driver, trips belong to passenger. We have this set up because it reflects the functionality required.
Describe the role of model validations in your application	When we create and edit drivers, passengers, and trips we make sure all the fields have been filled out.
How did your team break up the work to be done?	We distributed the tasks for the different pieces of the project and addressed the overlapping responsibilities in person.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to work on features (create,edit,destroy,etc.) for the driver and passenger controller before the trip since we won’t be able to create a trip without an existing driver and passenger. We did not get to work on 1 feature where we could add availability status for a driver and assign an available driver to a new trip. In addition, 2 of our tests on the create function of the trips controller did not pass as we used nested routes. We have not been able to fix those two tests yet. Even though those test fail, the create function for trips controller is working. Style has not been applied yet.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We liked the chance to apply the branching knowledge from this week and we have clarity on how to do it but there are still mysterious things happening beyond our understanding.
What is your Trello board URL?	https://trello.com/b/rBxk4Tas/rideshare
What is the Heroku URL of your deployed application?	https://nm-ride-share.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We did a good job providing and receiving feedback. We listened to each other's points of view and tried to apply them to our project.

…d, reset db to pull data from CSV into the database

…ay list of passengers in the navigation

…ts related

…thod in passenger controller

…nd show in drivers_controller

…oller-create method

CheezItMan · 2019-04-29T01:21:41Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	Good number of commits, no unnecessary files committed that I noticed. Try to avoid commit messages like `bleh`
Answered comprehension questions	Check
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check, good use of nested routes, You do have some routes which don't appear in the demo.
Project Requirements
Table relationships	Check
Business logic is in the models	Check
Controller tests	Check out your tests for update, you missed a few. Otherwise nice work!
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Very little styling
Overall	You have hit most of the learning goals. Things that aren't working as expected include creating trips, some small things in testing, styling, and some bugs in your controllers. It rather looks like you ran out of time. Take a look at my feedback and let me know questions that you have.

CheezItMan · 2019-04-26T20:28:39Z

test/controllers/trips_controller_test.rb

+      }
+
+      expect {
+        post passenger_trips_path, params: trip_create


This test is failing because this path is wrong. You need a route param for the passenger id.

post passenger_trips_path(Passenger.first.id)

It also doesn't need a params hash, because there is no form being submitted to the controller action.

CheezItMan · 2019-04-26T20:30:31Z

config/routes.rb

+  resources :drivers
+  resources :trips, except: [:new, :create, :update]
+  resources :passengers do
+    resources :trips, only: [:new, :create, :update]


Do you need the new form action?

Does the update action need to be nested inside passengers?

It is really good that you are making sure not to produce unused routes.

CheezItMan · 2019-04-26T20:33:16Z

app/controllers/trips_controller.rb

+    end
+  end
+
+  def new


Do you need a new action for trips?

The demo app has you create trips automatically without the form.

CheezItMan · 2019-04-26T20:36:39Z

app/views/trips/_form_trip.html.erb

+    <%= f.label :driver_id %>
+    <%= f.text_field :driver_id%>
+
+    <%= f.label :passenger_id%>


This should not be a text field, instead a select or something, something like what we have in the Ada Books with authors. Of course you should also have created trips without a form.

CheezItMan · 2019-04-26T22:54:30Z

app/models/trip.rb

+  belongs_to :driver
+  belongs_to :passenger
+
+  validates :driver_id, presence: :true


You don't need the validations for the foreign keys.

CheezItMan · 2019-04-29T01:12:52Z

test/controllers/trips_controller_test.rb


  describe "update" do
-    # Your tests go here
+    it "updates an existing trip" do


You don't have any test with invalid data and invalid trip id.

CheezItMan · 2019-04-29T01:13:37Z

test/controllers/drivers_controller_test.rb

+      expect(driver_to_update.vin).must_equal update_input[:driver][:vin]
+    end
+
+    it "will return a bad_request when trying to update with invalid data" do


You should also have a test when the driver id is invalid.

CheezItMan · 2019-04-29T01:18:38Z

app/controllers/drivers_controller.rb

+  def update
+    driver = Driver.find_by(id: params[:id])
+
+    is_successful = driver.update(driver_params)


If the driver isn't found, you have a problem...

CheezItMan · 2019-04-29T01:18:55Z

app/controllers/passengers_controller.rb

+  def update
+    passenger = Passenger.find_by(id: params[:id])
+
+    is_successful = passenger.update(passenger_params)


What about if the passenger isn't found?

CheezItMan · 2019-04-29T01:21:01Z

app/controllers/trips_controller.rb

+  end
+
+  def update
+    trip = Trip.find_by(id: params[:id])


Similar issue to other controllers.

lebaongoc and others added 30 commits April 15, 2019 15:44

created rails application

9fa8c21

added Passengers, Drivers, and Trips Controllers

e9622a3

Created driver, passenger, trip models

6132ce5

i have a new commit orginially on branch named branch-a

66864e9

This is a commit that belongs to new-branch

3e5c54d

Remove spurious model tests

a4f18f0

updated trips table to include foreign keys driver_id and passenger_i…

a46bf90

…d, reset db to pull data from CSV into the database

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

e46a5bb

added route for drivers

6feef39

added passengers resource in routes

2aed42e

debugged

de5d8fe

added index.html file to passengers folder in view

2243fdc

added index file for drivers and trips

85fd299

Create drivers index view

38e70a2

added index function for passenger controller and index view to displ…

0c6f4af

…ay list of passengers in the navigation

added show view for the drivers

0e17181

Added delete and edit links to driver

673c015

added edit form for driver show view

31094ff

added update action and driver params to controller

1967e49

edit view little adjustment

1df9d0a

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

b3dd0c5

added validation to edit driver view

3e8373f

deleted code from yml files in the fixture folder of controllers. Tes…

7dca9eb

…ts related

added show function for passenger along with edit, update, destroy me…

7ad889c

…thod in passenger controller

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

461e4e1

added partial form for update and new driver. created test for inde a…

540bfcc

…nd show in drivers_controller

added tests for passenger controller's index and show methods

47c9b8d

created test for driver controller create and update

5484019

added destroy test to drivers controller

7a9af9f

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

a6883ee

MyriamWD and others added 28 commits April 18, 2019 16:25

added test for trips show

6a42a20

added copyright hehe

da18e8d

added soft delete function for passengers controller

818426d

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

b573fc3

debugged

c1ba74e

trips destroy test

94e7066

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

0ae78c5

added deleted function for driver along with test

c4e1b92

added total cost method to passenger model

141d938

added tests for trip controller

bcaca9b

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

31cbddd

added links to delete and edit trip in driver and passenger show view

255bb1f

set the submit button of the partial form for drivers to a variable

a9aac30

added validation to edit and create partial form for trips

764b6dc

added create form to passenger

3e6ef38

minor changes

020e9b5

debugged

730fa27

debugged

78774a8

added default value for deleted field on drivers and passengers contr…

0a2dba9

…oller-create method

bleh

0a31fff

debbuged

0fc372f

added nested routes for trip & passenger

87324ed

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

137b6a2

fixed new and create method in trip controller & create new trip routes

7772bdd

updated trip controller test

3838abe

Merge branch 'master' of https://github.com/MyriamWD/ride-share-rails

c1ad287

driver model total earnings return fixed

3323ef8

adjusted nested routes for updating trips

0348fff

CheezItMan reviewed Apr 29, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ports- Ngoc-Myriam #17

Ports- Ngoc-Myriam #17

Uh oh!

MyriamWD commented Apr 19, 2019 •

edited

Loading

Uh oh!

CheezItMan commented Apr 29, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 29, 2019

Uh oh!

CheezItMan Apr 29, 2019

Uh oh!

CheezItMan Apr 29, 2019

Uh oh!

CheezItMan Apr 29, 2019

Uh oh!

CheezItMan Apr 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

+                  end
+                end
+                def new

Ports- Ngoc-Myriam #17

Are you sure you want to change the base?

Ports- Ngoc-Myriam #17

Uh oh!

Conversation

MyriamWD commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Apr 29, 2019

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MyriamWD commented Apr 19, 2019 •

edited

Loading