Accelerate -Cadence #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 19, 2021
| if goal is None: | ||
| return make_response("",404) | ||
| if request.method == "GET": | ||
| if goal is not None: |
There was a problem hiding this comment.
you don't need this line again because you already did the check
Suggested change
| if goal is not None: | |
tgoslee
reviewed
Jun 19, 2021
| }) | ||
| return make_response(jsonify(goal_reponse),200) | ||
|
|
||
| else: |
There was a problem hiding this comment.
want to make sure request.mthod == 'POST here
Suggested change
| else: | |
| elif request.method == 'POST': |
tgoslee
reviewed
Jun 19, 2021
Comment on lines
+182
to
+183
| goal_reponse=[] | ||
| goals = Goal.query.all() |
There was a problem hiding this comment.
move these after if request.method == 'GET':
tgoslee
reviewed
Jun 19, 2021
| if request.method == "GET": | ||
|
|
||
| for goal in goals: | ||
|
|
tgoslee
reviewed
Jun 19, 2021
Comment on lines
+14
to
+19
| def is_complete(completed_at): | ||
|
|
||
| if completed_at is None: | ||
| return False | ||
| else: | ||
| return True |
tgoslee
reviewed
Jun 19, 2021
| delete_id_response= f'Goal {goal_id} "{goal.title}" successfully deleted' | ||
| return make_response(jsonify({"details":delete_id_response})) | ||
|
|
||
| # @goals_bp.route('<goal_id>/tasks', methods=["GET", "POST"]) |
There was a problem hiding this comment.
To get tests passing for Wave 6 go ahead and implement what you started. Go back and look at the video if you need help with the implementation https://adaacademy.hosted.panopto.com/Panopto/Pages/Viewer.aspx?id=0e99645b-d46b-4e64-b5fe-ad48012e1e3e
tgoslee
reviewed
Jun 19, 2021
Comment on lines
+53
to
+69
| if request.method == "POST": | ||
| request_body = request.get_json() | ||
| if "title" not in request_body or "description" not in request_body or "completed_at" not in request_body: | ||
| return make_response({ | ||
| "details": "Invalid data" | ||
| }, 400) | ||
| else: | ||
| new_task = Task(title=request_body["title"], description=request_body["description"], completed_at=request_body["completed_at"]) | ||
| db.session.add(new_task) | ||
| db.session.commit() | ||
| return make_response( | ||
| { "task": { | ||
| "id": new_task.task_id, | ||
| "title": new_task.title, | ||
| "description": new_task.description, | ||
| "is_complete": is_complete(new_task.completed_at) | ||
| }}, 201) |
tgoslee
reviewed
Jun 19, 2021
Comment on lines
+139
to
+146
| data_response = { | ||
| "task": { | ||
| "id": task.task_id, | ||
| "title": task.title, | ||
| "description": task.description, | ||
| "is_complete": True | ||
| } | ||
| } |
tgoslee
reviewed
Jun 19, 2021
| if task.completed_at is None : | ||
| return make_response(jsonify(data_response),200) | ||
|
|
||
| task.completed_at = None |
tgoslee
reviewed
Jun 19, 2021
Comment on lines
+169
to
+170
| if task.completed_at is None : | ||
| return make_response(jsonify(data_response),200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.