Accelerate - Cloudy Lopez #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 10, 2021 20:58
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+4
to
+5
| from sqlalchemy import ForeignKey, update | ||
| from sqlalchemy.orm import relationship |
There was a problem hiding this comment.
you can remove these imports
Suggested change
| from sqlalchemy import ForeignKey, update | |
| from sqlalchemy.orm import relationship |
tgoslee
reviewed
Jun 25, 2021
| @@ -1,6 +1,11 @@ | |||
| from flask import current_app | |||
| from sqlalchemy.orm import backref | |||
There was a problem hiding this comment.
you can remove this import
Suggested change
| from sqlalchemy.orm import backref |
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+3
to
+4
| from sqlalchemy import ForeignKey, update | ||
| from sqlalchemy.orm import relationship |
There was a problem hiding this comment.
you can remove these imports
Suggested change
| from sqlalchemy import ForeignKey, update | |
| from sqlalchemy.orm import relationship |
tgoslee
reviewed
Jun 25, 2021
|
|
||
| @goals_bp.route("/<goal_id>", methods=["GET", "PUT", "DELETE"]) | ||
| def handle_goal(goal_id): | ||
| goal = Goal.query.get_or_404(goal_id) |
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+69
to
+72
| tasks = [] | ||
|
|
||
| for item in goal.tasks: | ||
| tasks.append(item) |
There was a problem hiding this comment.
You do not need to have this here. You are handling goals and tasks in the function you created handle_goal_tasks
Suggested change
| tasks = [] | |
| for item in goal.tasks: | |
| tasks.append(item) | |
| tasks = [] | |
tgoslee
reviewed
Jun 25, 2021
| selected_goal = {"goal": | ||
| {"id": goal.goal_id, | ||
| "title": goal.title, | ||
| "tasks": tasks |
There was a problem hiding this comment.
remove this line
Suggested change
| "tasks": tasks | |
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+81
to
+100
| elif request.method == "PUT": | ||
| form_data = request.get_json() | ||
| goal.title = form_data["title"] | ||
|
|
||
| db.session.commit() | ||
|
|
||
| committed_goal = {"goal": | ||
| {"id": goal.goal_id, | ||
| "title": goal.title, | ||
| }} | ||
| return jsonify(committed_goal), 200 | ||
|
|
||
| elif request.method == "DELETE": | ||
| db.session.delete(goal) | ||
| db.session.commit() | ||
| goal_response_body = { | ||
| "details": | ||
| f'Goal {goal.goal_id} successfully deleted' | ||
| } | ||
| return jsonify(goal_response_body) |
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+170
to
+175
| "task": { | ||
| "id": new_task.task_id, | ||
| "title": new_task.title, | ||
| "description": new_task.description, | ||
| "is_complete": completed_at | ||
| }}, 201) |
There was a problem hiding this comment.
Just like we talked about in the review session, how could you create a helper function instead of having to write this every time?
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+185
to
+186
| if not sort: | ||
| tasks = Task.query.all() |
There was a problem hiding this comment.
this should be handled by the else line in your conditional, so you wouldn't need this check here
tgoslee
reviewed
Jun 25, 2021
Comment on lines
+212
to
+214
| task = Task.query.get(task_id) | ||
| if task is None: | ||
| return make_response("No matching task found", 404) |
There was a problem hiding this comment.
use your get or 404 here that you used for goals!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wave one - passing some tests - not complete