Laurel - Cedar #56
Open
Laurel - Cedar #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grabbing this to grade! |
chimerror
reviewed
Jul 27, 2022
| @@ -1,19 +1,43 @@ | |||
|
|
|||
| from ntpath import join | |||
| from sqlalchemy import true | |||
There was a problem hiding this comment.
Looks like these import statements never got used, so you can remove them to keep the code clean as a good style practice.
| Space Complexity: ? | ||
| Time Complexity: O(n * m log m) | ||
| ^ Not sure on the time complexity. Here, n represents the number of words in the | ||
| input string, while m represents the length of an individual word. |
There was a problem hiding this comment.
This is correct!
However, we can make a simplifying assumption. Since we know the words are English words and English words do not get too long (about 5 letters per word on average), the effect they have on this algorithm is dwarfed by the number of words in the list (which could easily get in the hundreds and thousands for a big list).
Thus, we can just say this is O(n).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions