Skip to content

Conversation

rebecamuniz
Copy link

Hash Table Practice

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Why is a good Hash Function Important?
How can you judge if a hash function is good or not?
Is there a perfect hash function? If so what is it?
Describe a strategy to handle collisions in a hash table
Describe a situation where a hash table wouldn't be as useful as a binary search tree
What is one thing that is more clear to you on hash tables now

@rebecamuniz
Copy link
Author

final push

@chimerror
Copy link

Grabbing this to grade!

Copy link

@chimerror chimerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I added some comments about unneeded import statements, left-in debugging code, and missing complexity calculations on your top-K solution, but overall this looks good enough for a Green!

@@ -1,19 +1,48 @@

from array import array
from distutils.log import error
import string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these import statements didn't get used (they were probably added by an overzealous IDE), so you can remove them

@@ -26,4 +55,4 @@ def valid_sudoku(table):
Space Complexity: ?
"""
pass
print(top_k_frequent_elements([1, 2, 2, 2, 3, 3, 3], 2))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove testing code like this before checking in, just to keep the code clean for style purposes.

anagram_dict[a].append(sorted_word)
else:
anagram_dict[a] = [sorted_word]
return list(anagram_dict.values())

def top_k_frequent_elements(nums, k):
""" This method will return the k most common elements
In the case of a tie it will select the first occuring element.
Time Complexity: ?
Space Complexity: ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the complexity calculations got missed here, but I haven't been dinging people for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants