Mac P. #20
Open
Mac P. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jun 2, 2022
| @@ -1,8 +1,19 @@ | |||
|
|
|||
| from heapq import heappush, heappop | |||
|
|
|||
| def heap_sort(list): | |||
There was a problem hiding this comment.
✨ Time and space complexity? It would also be great to see you implement heap_sort using the MinHeap you implement below!
| larger than either of its children and continues until | ||
| the heap property is reestablished. | ||
| """ | ||
| pass | ||
| left_index = (index * 2) + 1 |
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: O(1) | ||
| Space complexity: O(n) |
There was a problem hiding this comment.
✨ However time and space complexity are O(log n) here because of the recursive call. heap_up will be called (log n) times because each time you are halving the index
| Time complexity: ? | ||
| Space complexity: ? | ||
| Time complexity: O(1) | ||
| Space complexity: O(1) |
|
|
||
| self.store.append(node) | ||
|
|
||
| self.heap_up(len(self.store) - 1) | ||
|
|
||
| def remove(self): |
There was a problem hiding this comment.
✨ However space complexity will be O(log n) because of the recursive call stack of heap_down
| """ Adds a HeapNode instance to the heap | ||
| If value == None the new node's value is set to key | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(n) |
There was a problem hiding this comment.
✨ However space complexity will just be O(log n) here because of the recursive call stack of heap_up. You aren't creating any other significant data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?