C16 Cedar LinkedLists #60
Conversation
| @@ -1,75 +1,136 @@ | |||
|
|
|||
| # Defines a node in the singly linked list | |||
| class Node: | |||
| from platform import node | |||
There was a problem hiding this comment.
where is this coming from? You've created your own Node class on line 6, so you don't need to import a third-party class
|
|
||
| class Node: |
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def get_first(self): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
| current = self.head | ||
| current = self.head |
There was a problem hiding this comment.
you have this twice
| current = self.head | |
| current = self.head | |
| current = self.head |
|
|
||
| current = self.head | ||
| current = self.head | ||
| while current.next is not None: |
There was a problem hiding this comment.
| while current.next is not None: | |
| while current.next: |
| if value == current.next.value: | ||
| break | ||
| current = current.next | ||
| if current.next is None: | ||
| print("Node not found") | ||
| else: | ||
| current.next = current.next.next |
There was a problem hiding this comment.
There's a couple if statements here that aren't really doing anything but stop the loop or print. It makes it hard to read what is important here. I think we can shorten it:
| if value == current.next.value: | |
| break | |
| current = current.next | |
| if current.next is None: | |
| print("Node not found") | |
| else: | |
| current.next = current.next.next | |
| if value == current.next.value: | |
| current.next = current.next.next | |
| current = current.next |
Since there could be more than one node with the same value, we don't want to break
| pass | ||
| prev = None | ||
| current = self.head | ||
| while current is not None: |
There was a problem hiding this comment.
| while current is not None: | |
| while current: |
| # Time Complexity: ? | ||
| # Space Complexity: ? |
There was a problem hiding this comment.
What do you think the space and time complexity of this is? Is the time complexity dependent on the length of the linked list? Is there any new variables being created that grow larger depending upon the input?
No description provided.