-
Notifications
You must be signed in to change notification settings - Fork 63
Cedar - Kristin L #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨🌸 Very nice work Kristin. I left some suggestions as to how you might simplify your stacks implementation, but your stack and queue look solid. Let me know what questions you have.
🟢
@@ -23,39 +23,75 @@ def enqueue(self, element): | |||
In the store are occupied | |||
returns None | |||
""" | |||
pass | |||
if self.size == self.buffer_size: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
self.store[self.rear] = element | ||
# reassigns rear usng mod | ||
self.rear = (self.rear + 1) % self.buffer_size | ||
self.size += 1 | ||
|
||
def dequeue(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
self.front = (self.front + 1) % self.buffer_size | ||
self.size -= 1 | ||
|
||
return front | ||
|
||
def front(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
pass | ||
if self.empty(): | ||
return None | ||
return self.front | ||
|
||
|
||
def size(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
||
|
||
def size(self): | ||
""" Returns the number of elements in | ||
The Queue | ||
""" | ||
pass | ||
return self.size | ||
|
||
def empty(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
pass | ||
if self.size == 0: | ||
return True | ||
return False | ||
|
||
def __str__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
@@ -12,7 +12,13 @@ def push(self, element): | |||
""" Adds an element to the top of the Stack. | |||
Returns None | |||
""" | |||
pass | |||
|
|||
self.store.add_last(element) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
# self.store.add_first(element) | ||
# return | ||
# self.store.tail.next = element | ||
# self.store.tail = element | ||
|
||
def pop(self): | ||
""" Removes an element from the top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ This will work, however you could also take advantage of the remove_last
method in the LinkedList
class
|
||
|
||
|
||
|
||
|
||
def empty(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ Again, this will work, however you could take advantage of LinkedList
's empty
method
if not self.store.head: | ||
return True | ||
return False | ||
|
||
|
||
def __str__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 Again, this works, but take a look at LinkedList
's str
method
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation