Spruce - Angela Fan #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jul 22, 2022
There was a problem hiding this comment.
🌸 Nice work, Angela. I left a comment on your __str__ implementation for queue - it doesn't quite consider all of the cases it needs to for a queue implemented with a circular buffer. Additionally, I'd like for you to fill out the comprehension questions for a green score. Let me know what questions you have.
🟡
| @@ -23,39 +22,63 @@ def enqueue(self, element): | |||
| In the store are occupied | |||
| returns None | |||
| """ | |||
| self.size += 1 | ||
| self.store[self.rear] = element | ||
| self.rear = (self.rear + 1) % self.buffer_size | ||
|
|
||
|
|
||
| def dequeue(self): | ||
| """ Removes and returns an element from the Queue | ||
| Raises a QueueEmptyException if | ||
| The Queue is empty. | ||
| """ |
| self.front += 1 | ||
| if self.front == self.buffer_size: | ||
| self.front = 0 | ||
| return element | ||
|
|
||
| def front(self): |
|
|
||
|
|
||
| def size(self): | ||
| """ Returns the number of elements in | ||
| The Queue | ||
| """ | ||
| pass | ||
| return self.size |
|
|
||
|
|
||
| def size(self): | ||
| """ Returns the number of elements in | ||
| The Queue | ||
| """ | ||
| pass | ||
| return self.size | ||
|
|
||
| def empty(self): |
|
|
||
| def __str__(self): | ||
| """ Returns the Queue in String form like: | ||
| [3, 4, 7] | ||
| Starting with the front of the Queue and | ||
| ending with the rear of the Queue. | ||
| """ | ||
| pass | ||
| return str(self.store[self.front:self.rear]) |
There was a problem hiding this comment.
This will only work in the case that the rear pointer has an index greater than that of the front index.
In the case that the rear pointer has wrapped around to the front of the queue, the rear pointer will be less than the front pointer and your code will end up returning an empty string.
| @@ -12,7 +12,7 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| return self.store.add_first(element) | |||
| if self.store.empty(): | ||
| raise StackEmptyException() | ||
| else: | ||
| return self.store.remove_first() |
|
|
||
| def empty(self): | ||
| """ Returns True if the Stack is empty | ||
| And False otherwise | ||
| """ | ||
| pass | ||
| return self.store.empty() |
|
|
||
| def __str__(self): | ||
| """ Returns the Stack in String form like: | ||
| [3, 4, 7] | ||
| Starting with the top of the Stack and | ||
| ending with the bottom of the Stack. | ||
| """ | ||
| pass | ||
| return str(self.store) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation