Initial editorial suggestions from T. Taft #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Tucker! These are all very helpful.
|
sttaft
force-pushed
the
sttaft_review
branch
from
f32e034 to
e0765f4
Compare
gusthoff
force-pushed
the
sttaft_review
branch
from
e0765f4 to
91969b1
Compare
Use subjunctive: ... as if it is ... => ... as if it were ...
Various editorial suggestions from T. Taft.
I found the use of "Enclosing" as a type name confusing, and so suggested replaceing "Enclosing" with "Device" and then using "Encloser" rather than "Instance" as the discriminant name. I also think the discussion of immutably limited, aliasedness, etc., is probably more than necessary, and was a bit imprecise in various ways. I have made some fixes, but I think you could probably simplify the whole discussion without losing much.
gusthoff
force-pushed
the
sttaft_review
branch
from
91969b1 to
a5fc122
Compare
gusthoff
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some editorial suggestions for the Ada Idioms course. I have reviewed about six of the idioms.