Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stacks_queues/linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
class EmptyListError(Exception):
pass

# Defines a node in the singly linked list
# Defines a node in the doubly linked list
class Node:
def __init__(self, value, next_node = None, previous_node = None):
self.value = value
Expand Down
45 changes: 37 additions & 8 deletions stacks_queues/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,49 +13,78 @@ def __init__(self):
self.store = [None] * INITIAL_QUEUE_SIZE
self.buffer_size = INITIAL_QUEUE_SIZE
self.front = -1
self.rear = -1
self.rear = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not really anything wrong with initializing this to 0, but since you reset it to '-1' in dequeue below when the queue becomes empty, it's best to stay consistent across the board.

Suggested change
self.rear = 0
self.rear = -1

self.size = 0


def enqueue(self, element):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Adds an element to the Queue
Raises a QueueFullException if all elements
In the store are occupied
returns None
"""
pass
if self.front == -1:
self.front = 0
self.rear = 0
elif self.size == self.buffer_size:
raise QueueFullException

self.store[self.rear] = element
self.rear = (self.rear + 1) % self.buffer_size
self.size += 1

def dequeue(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Removes and returns an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
"""
pass
if self.front == -1:
raise QueueEmptyException
else:
value = self.store[self.front]
self.front = (self.front + 1) % self.buffer_size
self.size -= 1
if self.front == self.rear:
self.front = -1
self.rear = -1
return value

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns an element from the front
of the Queue and None if the Queue
is empty. Does not remove anything.
"""
pass
if self.front == -1:
return None
return self.store[self.front]


def size(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ See minor suggestion below ⬇️

""" Returns the number of elements in
The Queue
"""
pass
if self.front == -1:
return 0
return self.size
Comment on lines +65 to +67

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since size should already be 0 if the queue is empty, you can probably delete lines 65 - 66.

Suggested change
if self.front == -1:
return 0
return self.size
return self.size


def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns True if the Queue is empty
And False otherwise.
"""
pass
return self.front == -1

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns the Queue in String form like:
[3, 4, 7]
Starting with the front of the Queue and
ending with the rear of the Queue.
"""
pass
result = []
index = self.front
size = self.size

for x in range(size):
result.append(self.store[index])
index = (index + 1) % self.buffer_size
size -= 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try not to change the value we are iterating through, and it's not necessary to modify size here.

Suggested change
size -= 1

return str(result)

8 changes: 4 additions & 4 deletions stacks_queues/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_first(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def pop(self):
""" Removes an element from the top
Expand All @@ -21,18 +21,18 @@ def pop(self):
The Stack is empty.
returns None
"""
pass
return self.store.remove_first()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def empty(self):
""" Returns True if the Stack is empty
And False otherwise
"""
pass
return self.store.empty()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


def __str__(self):
""" Returns the Stack in String form like:
[3, 4, 7]
Starting with the top of the Stack and
ending with the bottom of the Stack.
"""
pass
return str(self.store)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.