Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trello.com/c/txGIRwKv] Update the script for adamant-wallets #654

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

vovameister
Copy link
Collaborator

No description provided.

@vovameister vovameister changed the title [trello.com/c/txGIRwKv] [trello.com/c/txGIRwKv] Update the script for adamant-wallets Jan 19, 2025
Copy link
Collaborator

@ChrisBenua ChrisBenua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet services changes are fine

//
import Foundation

enum AdamantSecret {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here as I understand
@just-software-dev

@@ -257,3 +258,9 @@ extension AdmWalletService: SwinjectDependentService {
}
}
}

extension AdmWalletService {
static var adamantTimestampCorrection: TimeInterval {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplication. I'm also adding this constant to wallet-service and adamant app

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants