[trello.com/c/qTdMgopE] UI: Remove excessive spinner on pull down in Chats screen #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -428,7 +421,7 @@ final class ChatListViewController: KeyboardObservingViewController { | |||
| chatroom: chatroom, | |||
| messageIdToShow: messageId | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
remove excessive changes
|
|
||
| guard let result = result else { | ||
| return | ||
| } |
There was a problem hiding this comment.
Minor. If you can make code shorter — do it. guard let result = result else { return }
There was a problem hiding this comment.
or even guard let result = await chatsProvider.update(notifyState: true) else { return }
There was a problem hiding this comment.
Or do so
private func handleRefresh() async {
switch await chatsProvider.update(notifyState: true) {
case .some(.success):
tableView.reloadData()
case .some(.failure(let error)):
dialogService.showRichError(error: error)
case .none:
return
}
}
| @@ -594,6 +581,13 @@ extension ChatListViewController: UITableViewDelegate, UITableViewDataSource { | |||
| let offsetY = scrollView.contentOffset.y + scrollView.safeAreaInsets.top | |||
| scrollUpButton.isHidden = offsetY < cellHeight * 0.75 | |||
| } | |||
| func scrollViewDidEndDragging(_ scrollView: UIScrollView, willDecelerate decelerate: Bool) { | |||
| if scrollView.contentOffset.y <= 0 && scrollView.contentOffset.y < -100 { | |||
There was a problem hiding this comment.
Use guard to reduce nesting
| @@ -778,7 +772,7 @@ extension ChatListViewController: NSFetchedResultsControllerDelegate { | |||
| break | |||
| } | |||
|
|
|||
| // MARK: Unread controller | |||
| // MARK: Unread controller | |||
| return mutable.attributedSubstring(from: NSRange(location: 0, length: mutable.length)) | ||
| } else { | ||
| return description | ||
| } |
just-software-dev
requested changes
Jan 28, 2025
ChrisBenua
reviewed
Jan 28, 2025
| @@ -1408,14 +1402,14 @@ extension ChatListViewController { | |||
|
|
|||
| private func chatControllerIndexPath(tableViewIndexPath: IndexPath) -> IndexPath { | |||
| isBusy && tableViewIndexPath.row >= (lastSystemChatPositionRow ?? 0) | |||
| ? IndexPath(row: tableViewIndexPath.row - 1, section: 0) | |||
| : tableViewIndexPath | |||
| ? IndexPath(row: tableViewIndexPath.row - 1, section: 0) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace UIRefreshControl with scrollViewDidEndDragging to remove extra space while TableView refreshing.
ScreenRecording_01-27-2025.12-25-15_1.mp4