[trello.com/c/YrmN2oiR]: ERC20WalletService tests #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBenua
requested review from
art-divin,
just-software-dev,
Lainaaa and
PingPongEzZ
just-software-dev
approved these changes
Jan 30, 2025
ChrisBenua
force-pushed
the
trello.com/c/Htm0a2Qp
branch
from
6503ae7 to
4af9778
Compare
ChrisBenua
force-pushed
the
trello.com/c/YrmN2oiR
branch
from
e40137e to
72b6814
Compare
ChrisBenua
force-pushed
the
trello.com/c/Htm0a2Qp
branch
2 times, most recently
from
b3cd59f to
b2cb6e1
Compare
ChrisBenua
force-pushed
the
trello.com/c/YrmN2oiR
branch
from
72b6814 to
3f0fe9b
Compare
Lainaaa
approved these changes
Feb 1, 2025
ChrisBenua
force-pushed
the
trello.com/c/YrmN2oiR
branch
from
3f0fe9b to
21c95d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
ERC20WalletServicetests.Main logic is the same as in
EthWalletServicetests, but there are specific cases where I spent most of time trying to figure out.For example, to get
multiplierfor current token, API call is used. I mock it usingmakeDecimalsMockand its response looks like0x0000000000000000000000000000000000000000000000000000000000000006.Additionally
ERC20ApiServiceProtocolMockwas needed to proxy all URL calls through customWeb3Providerwith out customURLSession