Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Notes] Add AJO Decisioning extension 1.1.0 release notes #753

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mohdashraf010897
Copy link

@mohdashraf010897 mohdashraf010897 commented Feb 5, 2025

Description:

Added release notes for Adobe Journey Optimizer - Decisioning extension version 1.1.0, which introduces configuration capability for request timeout in the Launch UI.

Related Jira Ticket

MOB-22787

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amadt amadt requested a review from addb February 5, 2025 19:06
@amadt
Copy link

amadt commented Feb 5, 2025

@addb Can you verify. I don't know requirements for this repo

@addb addb requested a review from calebk1 February 5, 2025 19:39
Copy link
Contributor

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments!

These comments apply for both the one in adobe-journey-optimizer-decisioning, as well as the main release notes page.


### Adobe Journey Optimizer - Decisioning extension 1.1.0

Added configuration capability to the Adobe Journey Optimizer - Decisioning extension in the Launch UI for mobile Tag Properties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it's not called Launch any more - so this has to be (and I'm so sorry for how stupid this sounds) ".... in the Tags UI for mobile Tag Properties.".

* Added timeout (in seconds) parameter to updatePropositions and getPropositions APIs to enable timeout configuration in both the apis ensuring that the operation either completes within the given time frame or returns an error indicating a timeout.
* Updated getPropositions API to return cached propositions immediately if there are no pending updatePropositions calls for the requested list of decision scopes.
* Added support for debug events and enabled getPropositions and onPropositionsUpdate to receive Simulated events from Assurance.
* Added timeout (in seconds) parameter to updatePropositions and getPropositions APIs to enable timeout configuration in both the apis ensuring that the operation either completes within the given time frame or returns an error indicating a timeout.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit - let's be consistent for how we format "APIs" - so make it "... in both the APIs that the operation..."

* Added support for debug events and enabled getPropositions and onPropositionsUpdate to receive Simulated events from Assurance.
* Added timeout (in seconds) parameter to updatePropositions and getPropositions APIs to enable timeout configuration in both the apis ensuring that the operation either completes within the given time frame or returns an error indicating a timeout.
* Updated getPropositions API to return cached propositions immediately if there are no pending updatePropositions calls for the requested list of decision scopes.
* Added support for debug events and enabled getPropositions and onPropositionsUpdate to receive Simulated events from Assurance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Simulated" a proper noun here? I'd just go with "... to receive simulated events..." if not.

@mohdashraf010897
Copy link
Author

bffe393
Thanks @calebk1

The comments have been addressed - bffe393

@mohdashraf010897 mohdashraf010897 marked this pull request as draft February 6, 2025 09:39
@mohdashraf010897
Copy link
Author

Switching this PR into draft, will mark it ready once the respective iOS and Android messaging SDKs are released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants