Use TextLayout instead of TextType #120
Conversation
| @@ -224,7 +230,7 @@ You must provide trader details by February 16, 2025, to keep your add-on visibl | |||
| - Added many new **Text APIs** for improved text management. | |||
| - [`TextNode.fullContent`](./document-sandbox/document-apis/classes/TextNode.md#fullcontent) accessor: returns the [`TextContentModel`](./document-sandbox/document-apis/classes/TextContentModel.md) containing the complete text string and its styles associated to the Text Flow (Threaded Text or Overflow Text). | |||
| - [`TextNode.nextTextNode`](./document-sandbox/document-apis/classes/TextNode.md#nexttextnode) accessor: gets the next node that overflowing text will spill into. | |||
| - [`TextNode.layout`](./document-sandbox/document-apis/classes/TextNode.md#layout) accessor: gets and sets the [`TextType`](./document-sandbox/document-apis/enumerations/TextType.md) of the text node frame. | |||
| - [`TextNode.layout`](./document-sandbox/document-apis/classes/TextNode.md#layout) accessor: gets and sets the [`TextLayout`](./document-sandbox/document-apis/enumerations/TextLayout.md) of the text node frame. | |||
There was a problem hiding this comment.
Nit: this particular change seems ok but we should be careful about updating descriptions of older API changes to reflect the latest state of the API. That may be confusing since this description is now mixing old and new and may not accurately describe any state the API has ever existed in.
In some cases it might even be impossible to keep the links in older changelog entries up to date, e.g. if an API has changed a lot or was removed. We should probably decide a policy for how much to update these entries and what to do if it's impossible to keep links working (would we rather leave the older link and let is 404, or strip the link out of the text, or add a new parenthetical note that links to the newer equivalent API, etc.).
There was a problem hiding this comment.
You've hit a nerve, @peterflynn! I always struggle with links in the changelog. @nimithajalal suggested archiving the oldest entries, which I'm all in for.
IIRC, the linter is part of the build script, and it'd prevent the merge if it found something wrong there—so we're in this weird situation where we need to fix links even if they've stopped making sense.
Description
Renamed TextType enum to TextLayout
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: