-
Notifications
You must be signed in to change notification settings - Fork 113
[PaymentsAPIs] Code generation: update services and models #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request contains automatically generated code updates for the Payments APIs. The changes primarily involve minor code formatting adjustments, updates to PHPDoc comments for various model properties, and small modifications to service API files, reflecting recent OpenAPI specification changes.
Highlights
- Code Formatting & Style: Minor formatting adjustments were applied to foreach loops and if statements within ObjectSerializer.php files across multiple API modules (BinLookup, Checkout, Disputes, Payments, PaymentsApp, Payout, PosMobile, Recurring, StoredValue) for consistency.
- PHPDoc Documentation Updates: Updated PHPDoc comments for various model properties, including shopperEmail, shopperIP, telephoneNumber, and threeDSAuthenticationOnly in Payment and Payout related models, to provide more precise details on 3D Secure 2 authentication requirements and other field behaviors. Descriptions for subMerchantSubSellerSubSellerNrName, fraudRiskLevel, and addrMatch were also refined.
- Service API Minor Adjustments: Small, non-functional changes were made to service API files, such as adding blank lines for formatting in RecurringApi.php (Checkout) and UtilityApi.php (Checkout), and RecurringApi.php (Root).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be auto-generated and mostly contains updates to documentation comments. However, I've noticed some coding style violations in the ObjectSerializer.php
files that go against PSR-12 standards. Specifically, foreach
loops are missing a space after the keyword, and some if
statements are written on a single line without braces. I've added comments on one of the files with suggestions to fix these. Please apply these fixes to all ObjectSerializer.php
files to maintain code consistency and readability.
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PSR-12, the body of an if
statement must be enclosed in braces. This prevents potential bugs when adding more lines to the body and improves readability.1
if (!is_string($timestamp)) {
return $timestamp;
}
Style Guide References
Footnotes
-
PSR-12 Section 5: The body of each control structure MUST be enclosed in braces. This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. ↩
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PSR-12, the body of an if
statement must be enclosed in braces. This prevents potential bugs when adding more lines to the body and improves readability.1
if (!is_string($timestamp)) {
return $timestamp;
}
Style Guide References
Footnotes
-
PSR-12 Section 5: The body of each control structure MUST be enclosed in braces. This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. ↩
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PSR-12, the body of an if
statement must be enclosed in braces. This prevents potential bugs when adding more lines to the body and improves readability.1
if (!is_string($timestamp)) {
return $timestamp;
}
Style Guide References
Footnotes
-
PSR-12 Section 5: The body of each control structure MUST be enclosed in braces. This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. ↩
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PSR-12, the body of an if
statement must be enclosed in braces. This prevents potential bugs when adding more lines to the body and improves readability.1
if (!is_string($timestamp)) {
return $timestamp;
}
Style Guide References
Footnotes
-
PSR-12 Section 5: The body of each control structure MUST be enclosed in braces. This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. ↩
@@ -82,7 +82,7 @@ public static function sanitizeForSerialization($data, $type = null, $format = n | |||
} | |||
} | |||
} else { | |||
foreach ($data as $property => $value) { | |||
foreach($data as $property => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!is_string($timestamp)) { | ||
return $timestamp; | ||
} | ||
if (!is_string($timestamp)) return $timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PSR-12, the body of an if
statement must be enclosed in braces. This prevents potential bugs when adding more lines to the body and improves readability.1
if (!is_string($timestamp)) {
return $timestamp;
}
Style Guide References
Footnotes
-
PSR-12 Section 5: The body of each control structure MUST be enclosed in braces. This standardizes how the structures look and reduces the likelihood of introducing errors as new lines are added to the body. ↩
9e3c34d
to
741afc3
Compare
[reformat][adyen-sdk-automation] automated changes
741afc3
to
0267449
Compare
|
OpenAPI spec files or templates have been modified on 05-08-2025 by commit.