Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cosmic-swingset): Add test coverage for Prometheus output #10954

Open
wants to merge 6 commits into
base: gibson-10937-update-opentelemetry
Choose a base branch
from

Conversation

gibson042
Copy link
Member

Extends #10941
Fixes #10911

Description

Extracts a testable launchChain unit in packages/cosmic-swingset/src/chain-main.js, and uses that for an ava snapshot test of localhost:${OTEL_EXPORTER_PROMETHEUS_PORT}/metrics. Includes incidental fixes and utility additions along the way (and therefore best reviewed by commit).

Security Considerations

None known.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Just the usual --update-snapshots when things change.

Upgrade Considerations

n/a

@gibson042 gibson042 requested a review from mhofman February 6, 2025 03:58
@gibson042 gibson042 requested a review from a team as a code owner February 6, 2025 03:58
@gibson042 gibson042 force-pushed the gibson-10911-prometheus-snapshot branch from af8cdb2 to 799daa7 Compare February 6, 2025 04:31
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 452567e
Status: ✅  Deploy successful!
Preview URL: https://e2eaa1d6.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-10911-prometheus-snap.agoric-sdk.pages.dev

View logs

@gibson042 gibson042 changed the base branch from master to gibson-10937-update-opentelemetry February 6, 2025 04:34
@gibson042 gibson042 force-pushed the gibson-10911-prometheus-snapshot branch from 799daa7 to 452567e Compare February 6, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snapshot test of prometheus metrics
1 participant