Support h3 #572
Open
Support h3 #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hansott
reviewed
Apr 4, 2025
library/sources/H3.ts
Outdated
| return [wrapEventHandler(args[0] as EventHandler, h3)]; | ||
| } | ||
|
|
||
| if (args[0] && typeof args[0] === "object" && !Array.isArray(args[0])) { |
library/sources/H3.ts
Outdated
| // Can be a function or a array of functions | ||
| if (typeof config[func] === "function") { | ||
| config[func] = wrapMiddleware( | ||
| config[func] as (...args: unknown[]) => void | Promise<void>, |
There was a problem hiding this comment.
Extract type for (...args: unknown[]) => void | Promise<void>?
library/sources/H3.ts
Outdated
| } | ||
|
|
||
| private wrapCreateApp(args: unknown[], h3: typeof import("h3")) { | ||
| if (args.length < 1 || typeof args[0] !== "object" || !args[0]) { |
There was a problem hiding this comment.
Suggested change
| if (args.length < 1 || typeof args[0] !== "object" || !args[0]) { | |
| if (args.length === 0 || typeof args[0] !== "object" || !args[0]) { |
Co-authored-by: Hans Ott <[email protected]>
|
Probably need install docs? |
* 'main' of github.com:AikidoSec/node-RASP: (166 commits) Let all benchmarks run even if one fails Pass `t` in function Format Add test case for use case Revert "Add more test cases" Add more test cases Speed up safeDecodeURIComponent unit tests Allow access to route if exact match does Rename variable to make it more clear Remove redundant methods Improve comment Remove `isMonitoredIPAddress` Use userAgent variable Iterate through monitored IP lists only once Add comment about empty string and regexp Refactor safeCreateRegExp to its own file Fix end2end test Fix missing imports Format file Add end2end test to ensure monitored IPs and user agents are never blocked ...
hansott
reviewed
May 16, 2025
| }; | ||
|
|
||
| // eslint-disable-next-line camelcase | ||
| handler.__is_handler__ = true; |
There was a problem hiding this comment.
Not sure why this is added? Can't find this in h3 codebase?
Wouldn't it be okay to require something from h3 so that we don't have to do this?
There was a problem hiding this comment.
Only on mobile right now, but it was added in H3 codebase. Importing is always a bit problematic with bundlers, no?
| if (!(key in object)) { | ||
| object[key] = value; | ||
| return; | ||
| } |
| @@ -8,4 +8,4 @@ Try the following URLs: | |||
|
|
|||
| - http://localhost:4000/ : List all cats | |||
| - http://localhost:4000/?petname=Kitty : This will add a new cat named "Kitty" | |||
| - http://localhost:4000/?petname=Kitty'); DELETE FROM cats;-- H : This will delete all cats | |||
| - http://localhost:4000/?petname=Kitty'); DELETE FROM cats_3;-- H : This will delete all cats | |||
Co-authored-by: Hans Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://h3.unjs.io
https://www.npmjs.com/package/h3