Skip to content

Add rubygems support#305

Open
bitterpanda63 wants to merge 5 commits intomainfrom
feat/ruby-firewall-rule
Open

Add rubygems support#305
bitterpanda63 wants to merge 5 commits intomainfrom
feat/ruby-firewall-rule

Conversation

@bitterpanda63
Copy link
Copy Markdown
Member

@bitterpanda63 bitterpanda63 commented Apr 16, 2026

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 1 Resolved Issues: 0

🚀 New Features

  • Added RubyGems package firewall rule, parser, tests, and integration

More info

_ => default_ecosystem_policy.clone(),
};

let ruby_policy = match token {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ruby_policy which duplicates the existing per-ecosystem policy match blocks; this repeats substantial logic and JSON structure already present.

Details

✨ AI Reasoning
​​1) The change adds a new ruby_policy match block that mirrors existing per-ecosystem policy match blocks.
​2) This repeats the same logical pattern and JSON shape used for other ecosystems.
​3) The repetition increases maintenance burden because fixes to policy-shape handling would need multiple places updated.
​4) The duplication is within the same file and was introduced by this PR.

🔧 How do I fix it?
Delete extra code. Extract repeated code sequences into reusable functions or methods. Use loops or data structures to eliminate repetitive patterns.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant