[Aikido] Fix 4 security issues in lodash, picomatch#28
Open
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Open
[Aikido] Fix 4 security issues in lodash, picomatch#28aikido-autofix[bot] wants to merge 1 commit intomainfrom
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade lodash and picomatch to fix critical RCE vulnerability in template compilation via prototype pollution and unsafe imports, plus medium ReDoS and integrity issues in glob matching.
✅ Code not affected by breaking changes.
✅ No breaking changes from the lodash upgrade affect this codebase.
The codebase uses
_.template()ingcp-test/tint.js:113, but it does not pass animportsoption, so the breaking change regarding forbidden identifier characters in imports does not apply.The methods
_.unset()and_.omit()are not used anywhere in the codebase, so the breaking change blockingconstructorandprototypepath keys does not apply.All breaking changes by upgrading lodash from version 4.17.23 to 4.18.1 (CHANGELOG)
_.unset/_.omitnow blockconstructorandprototypeas non-terminal path keys unconditionally. Calls that previously returnedtrueand deleted the property now returnfalseand leave the target untouched._.templatenow throws"Invalid imports option passed into _.template"whenimportskeys contain forbidden identifier characters, which were previously allowed.✅ 4 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
🔗 Related Tasks