-
Notifications
You must be signed in to change notification settings - Fork 7
Prepare repo for PyPI packaging #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @ahmedsobeh, thanks for this... one question... when I run:
I get
Should the
be
? |
* [The Aiven CLI](https://github.com/aiven/aiven-client) to connect and create services | ||
* The Python packages in the `requirements.txt` file to push data to Grafana | ||
|
||
Before starting it, please install the required dependences, login with the [Aiven CLI](https://github.com/aiven/aiven-client) and execute: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth explaining that one can use pip install -r aiven_metadata_parser/requirements.txt
to install the Python packages (perhaps in the list item that mentions that file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's mentioned in line #46 already
Thanks for the commit! Just saw your comment now |
Co-authored-by: Tibs (Tony Ibbs) <[email protected]>
About this change - What it does
This PR prepares the repo for packaging on PyPI. the file hierarchy is changed and setup.cfg, setup.py and a new folder for packaging have been added.
Why this way
this is the typical method to package a python package on PyPI.