Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

feat: add monorepo #35

Merged
merged 6 commits into from
Mar 23, 2024
Merged

feat: add monorepo #35

merged 6 commits into from
Mar 23, 2024

Conversation

tobySolutions
Copy link
Member

@tobySolutions tobySolutions commented Mar 20, 2024

Description of the pull request

This is the pull request to integrate Mono repo support for the bun project. I followed two resources to achieve this current version in my pull request:

Changes made

  • Setup the root package.json
  • Created the packages folder and move the backend code to a folder called sprout-server
  • add the .gitignore file to the root
  • ....

Related issues

Testings done

Screenshots (if any)

Checklist

  • I have written tests
  • My code does not produce new errors
  • I gave myself a code review before asking others.

Please help review @GuiBibeau, @chin-flags

@cxalem
Copy link
Collaborator

cxalem commented Mar 20, 2024

I wonder if there's a way to use turborepo with Bun 🤔

@tobySolutions
Copy link
Member Author

I wonder if there's a way to use turborepo with Bun 🤔

I think we can actually, but, would we be using turborepo to handle the mono-repo support?

@cxalem
Copy link
Collaborator

cxalem commented Mar 20, 2024

I wonder if there's a way to use turborepo with Bun 🤔

I think we can actually, but, would we be using turborepo to handle the mono-repo support?

This is working really good already! Turborepo is an option to scale our monorepo, but we could implement it later without a problem if we decide it's needed. I would like to know @GuiBibeau and @chin-flags opinions also! 😅

@tobySolutions
Copy link
Member Author

I wonder if there's a way to use turborepo with Bun 🤔

I think we can actually, but, would we be using turborepo to handle the mono-repo support?

This is working really good already! Turborepo is an option to scale our monorepo, but we could implement it later without a problem if we decide it's needed. I would like to know @GuiBibeau and @chin-flags opinions also! 😅

Yeah, I see your point actually. I'd love to hear their opinions as well.

Copy link
Collaborator

@GuiBibeau GuiBibeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if 🔥 🎸

two small changes requested:

  • Let's rm -rf .DS_Store to ensure we don't track the file.
  • removing the docker commands and files

@tobySolutions
Copy link
Member Author

This if 🔥 🎸

two small changes requested:

  • Let's rm -rf .DS_Store to ensure we don't track the file.
  • removing the docker commands and files

These have been resolved. I removed the file, added the scripts and removed the docker configs.

@GuiBibeau GuiBibeau merged commit 39bb433 into main Mar 23, 2024
1 check passed
@tobySolutions tobySolutions mentioned this pull request Mar 23, 2024
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants