This repository was archived by the owner on Sep 18, 2024. It is now read-only.
feat: add-homepage #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GuiBibeau
suggested changes
Apr 12, 2024
There was a problem hiding this comment.
Really beautiful first touch! I would prefer that we stay away from hard coded style values as much as possible in tailwind in favour of using the base style system they provide.
For example:
mt-[20px] should become mt-5.
A quick tip to get those quickly is to use cmd+k in the tailwind docs:
packages/akeru-frontend/app/components/layout/header/header.tsx
Outdated
Show resolved
Hide resolved
packages/akeru-frontend/app/components/layout/header/header.tsx
Outdated
Show resolved
Hide resolved
GuiBibeau
reviewed
Apr 13, 2024
GuiBibeau
reviewed
Apr 13, 2024
Co-authored-by: Gui Bibeau <[email protected]>
GuiBibeau
approved these changes
Apr 14, 2024
Yay!!!!!!!!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Changes made
This PR fixes #51
....
Related issues
Testings done
Screenshots (if any)
Checklist