Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

review readme #62

Merged
merged 1 commit into from
Apr 15, 2024
Merged

review readme #62

merged 1 commit into from
Apr 15, 2024

Conversation

GuiBibeau
Copy link
Collaborator

Description of the pull request

Reviews the readme to explain more the goals and purpose of Akeru.

Changes made

delete test run in pre hook, these will be done in CI/CD instead

Related issues

Testings done

Screenshots (if any)

Checklist

  • I have written tests
  • My code does not produce new errors
  • I gave myself a code review before asking others.

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
akeru-akeru-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 4:23pm

Copy link
Member

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually LGTM @GuiBibeau. Wait, so does this mean we'll add the information for people to contribute in a "Contributing guideline" maybe?

@GuiBibeau
Copy link
Collaborator Author

This actually LGTM @GuiBibeau. Wait, so does this mean we'll add the information for people to contribute in a "Contributing guideline" maybe?

@tobySolutions yes indeed. Now contributing becomes more complicated and needs to take into account if you are contributing to the subnet only or the AI Platform layer only or even both. We'll need to review that in a bigger page that explains well the boundaries of each areas

@GuiBibeau GuiBibeau merged commit 2f15a9f into main Apr 15, 2024
3 checks passed
@tobySolutions
Copy link
Member

This actually LGTM @GuiBibeau. Wait, so does this mean we'll add the information for people to contribute in a "Contributing guideline" maybe?

@tobySolutions yes indeed. Now contributing becomes more complicated and needs to take into account if you are contributing to the subnet only or the AI Platform layer only or even both. We'll need to review that in a bigger page that explains well the boundaries of each areas

That makes actually. I agree with you on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants