Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

fix: button background contrast #69

Closed
wants to merge 1 commit into from
Closed

fix: button background contrast #69

wants to merge 1 commit into from

Conversation

icarodredd
Copy link

@icarodredd icarodredd commented Apr 16, 2024

Description of the pull request

i changed the background color to via-900

Changes made

  • class="bg-gradient-to-b from-green-800 via-green-900 to-green-950"

Related issues

Testings done

Screenshots (if any)

Checklist

  • I have written tests
  • My code does not produce new errors
  • I gave myself a code review before asking others.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
akeru-akeru-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 2:03pm

@GuiBibeau
Copy link
Collaborator

Thanks a lot for this! Please fill out the PR description. Reviewing now

@icarodredd
Copy link
Author

icarodredd commented Apr 16, 2024

close #69

@cxalem
Copy link
Collaborator

cxalem commented Apr 16, 2024

I would say it's better to change the button color on mobile than to change the background color!

This is because the background pattern looks incomplete if we do this.

Another way to solve this is to change the background color only on mobile.

@GuiBibeau
Copy link
Collaborator

@cxalem or @tobySolutions can one of you give this a second review. I'm a bit removed from the UI currently

@icarodredd
Copy link
Author

I would say it's better to change the button color on mobile than to change the background color!

This is because the background pattern looks incomplete if we do this.

Another way to solve this is to change the background color only on mobile.

Yaya, but i don't see a big difference changing this. Well i left the decision for the owner and others contributors

@tobySolutions
Copy link
Member

tobySolutions commented Apr 16, 2024

I would say it's better to change the button color on mobile than to change the background color!
This is because the background pattern looks incomplete if we do this.
Another way to solve this is to change the background color only on mobile.

Yaya, but i don't see a big difference changing this. Well i left the decision for the owner and others contributors

I agree with @cxalem's suggestion on this. That's the preferred solution, right now.

@GuiBibeau GuiBibeau self-requested a review April 16, 2024 21:05
@GuiBibeau
Copy link
Collaborator

Agree with @cxalem and @tobySolutions on this

@icarodredd icarodredd closed this by deleting the head repository Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants