Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

Hero Section Button Bg Issue Solved #68 #70

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

CKsabari2001
Copy link
Contributor

Description of the pull request

This pull request addresses the issue with the background gradient class used in the HTML. The problem arose when the bottom background color of the gradient matched the button background color, causing visual blending, especially on devices with low screen height. To mitigate this issue, the background color of the HTML tag has been slightly lightened to create a clearer distinction between the background and button colors on such devices.

Additionally, the footer background color has been removed to ensure a seamless transition between the modified background color of the HTML tag and the footer, preventing any visual inconsistencies caused by conflicting background colors.

Changes made

  • Adjusted the background color of the HTML tag to provide better contrast with the button background color on low screen height devices.
  • Removed the footer background color to maintain visual harmony with the modified background color of the HTML tag.

Related issues

Closes #68

Testings done

To test this PR:

  1. View the website on devices with low screen height to verify improved contrast between background and button colors.
  2. Check for any visual inconsistencies between the modified HTML background color and the footer.

Screenshots (if any)

image
image

Checklist

  • I have written tests
  • My code does not produce new errors
  • I gave myself a code review before asking others.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
akeru-akeru-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 9:50am

Copy link
Collaborator

@GuiBibeau GuiBibeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete the package.lock, the project uses bun.

Thank you for the PR!

@cxalem
Copy link
Collaborator

cxalem commented Apr 16, 2024

I would say it's better to change the button color on mobile than to change the background color!

This is because the background pattern looks incomplete if we do this.

Another way to solve this is to change the background color only on mobile.

@CKsabari2001
Copy link
Contributor Author

@GuiBibeau sure I will remove package.lock

@CKsabari2001
Copy link
Contributor Author

@cxalem, I believe altering the button color solely for mobile devices may not provide the ideal solution. Instead, adjusting the background color for mobile devices should be the optimal choice. Alternatively, modifying the button color for both mobile and desktop platforms could also be considered.

@tobySolutions
Copy link
Member

@cxalem, I believe altering the button color solely for mobile devices may not provide the ideal solution. Instead, adjusting the background color for mobile devices should be the optimal choice. Alternatively, modifying the button color for both mobile and desktop platforms could also be considered.

I think we should go ahead with @cxalem said. It's actually the very preferable solution right now.

Copy link
Collaborator

@GuiBibeau GuiBibeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@GuiBibeau GuiBibeau merged commit d526015 into AkeruAI:main Apr 17, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home button on mobile has a weird bg-color to page-bg contrast
4 participants