-
Notifications
You must be signed in to change notification settings - Fork 17
Hero Section Button Bg Issue Solved #68 #70
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete the package.lock, the project uses bun.
Thank you for the PR!
I would say it's better to change the button color on mobile than to change the background color! This is because the background pattern looks incomplete if we do this. Another way to solve this is to change the background color only on mobile. |
@GuiBibeau sure I will remove package.lock |
@cxalem, I believe altering the button color solely for mobile devices may not provide the ideal solution. Instead, adjusting the background color for mobile devices should be the optimal choice. Alternatively, modifying the button color for both mobile and desktop platforms could also be considered. |
I think we should go ahead with @cxalem said. It's actually the very preferable solution right now. |
This reverts commit bab4660.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Description of the pull request
This pull request addresses the issue with the background gradient class used in the HTML. The problem arose when the bottom background color of the gradient matched the button background color, causing visual blending, especially on devices with low screen height. To mitigate this issue, the background color of the HTML tag has been slightly lightened to create a clearer distinction between the background and button colors on such devices.
Additionally, the footer background color has been removed to ensure a seamless transition between the modified background color of the HTML tag and the footer, preventing any visual inconsistencies caused by conflicting background colors.
Changes made
Related issues
Closes #68
Testings done
To test this PR:
Screenshots (if any)
Checklist