Add randomChoice utility

Signed-off-by: Momozor <[email protected]>
AkiraList · May 25, 2021 · b347e18 · b347e18
1 parent 2fd5e7e
commit b347e18
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/Src/Controllers/Admin.js b/Src/Controllers/Admin.js
@@ -1,6 +1,5 @@
 const APIKEYS = require('../../models/apikeys')
-
-const uuid = require('../Utilities/functions').uuid
+const { uuid } = require('../Utilities/functions')
 
 exports.newAPIKEY = async (req, res, next) => {
   try {
@@ -29,7 +28,7 @@ exports.newAPIKEY = async (req, res, next) => {
       apikey: key
     })
 
-    res.render('main', { message: 'success', key })
+    res.render('main', { message: 'success', key })
   } catch (error) {
     console.log(error)
     if (error.code === 11000) {
@@ -40,4 +39,4 @@ exports.newAPIKEY = async (req, res, next) => {
       })
     }
   }
-}
+}
diff --git a/Src/Utilities/functions.js b/Src/Utilities/functions.js
@@ -1,10 +1,12 @@
 const randomNumber = function (length) {
   return Math.floor(Math.random() * length)
 }
+const randomChoice = function (list) {
+  return list[randomNumber(list.length)]
+}
 const randomCharacter = function (string) {
   return string.charAt(randomNumber(string.length))
 }
-
 const randomString = function (length, from = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789') {
   return Array(length).fill().map(function () {
     return randomCharacter(from)
@@ -13,6 +15,7 @@ const randomString = function (length, from = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefg
 
 module.exports = {
   randomNumber,
+  randomChoice,
   randomCharacter,
   randomString,
   uuid: function () {
@@ -85,9 +88,7 @@ module.exports = {
   sarcasticConverter: function (string) {
     const possibleOutcomes = ['low', 'high']
     const outcome = function () {
-      return possibleOutcomes[
-        randomNumber(possibleOutcomes.length)
-      ]
+      return randomChoice(possibleOutcomes)
     }
 
     return string.split('').map(function (character) {

diff --git a/tests/unit/utilities/functions.test.js b/tests/unit/utilities/functions.test.js
@@ -5,6 +5,10 @@ describe('Utility functions', function () {
     expect(functions.randomNumber(11))
       .toBeLessThan(11)
   })
+  it('returns a random object from a list', function () {
+    expect(functions.randomChoice(['high', 'low', 'medium']))
+      .toMatch(/^high|low|medium$/)
+  })
   it('returns a random character from a string', function () {
     expect(functions.randomCharacter('ABCDE'))
       .toMatch(/^[A-E]$/)