-
Notifications
You must be signed in to change notification settings - Fork 1
DEPRECATION: add deprecation warning to this package #158
DEPRECATION: add deprecation warning to this package #158
Conversation
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request adds a deprecation warning to the README file of the old form element repositories, recommending migration to the new Auro Formkit. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a date for when the deprecation will take effect.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Checkbox | ||
# Checkbox (DEPRECATED) | ||
|
||
> **WARNING:** This component is deprecated and is no longer supported. Please migrate to the new [Auro Formkit](https://github.com/AlaskaAirlines/auro-formkit) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "Auro Formkit" should be "auro-formkit"
The project name is "auro-formkit" (lowercase with a hyphen), as seen in the GitHub repository. The documentation should match this.
> **WARNING:** This component is deprecated and is no longer supported. Please migrate to the new [Auro Formkit](https://github.com/AlaskaAirlines/auro-formkit) instead. | |
> **WARNING:** This component is deprecated and is no longer supported. Please migrate to the new [auro-formkit](https://github.com/AlaskaAirlines/auro-formkit) instead. |
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Chores: