-
Notifications
You must be signed in to change notification settings - Fork 2
DEPRECATION: add deprecation warning to this package #226
Conversation
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request adds a deprecation warning to the auro-combobox component and updates the documentation build process to accommodate deprecated components. The changes involve adding a warning message to the README, updating the documentation build script, and adding new files for documentation generation. Updated class diagram for the deprecatedDocsProcessorclassDiagram
class deprecatedDocsProcessor {
+fileConfigs()
+processDocFiles(config)
}
class fileConfigs {
+identifier: string
+input: string
+output: string
+mdMagicConfig: object
+preProcessors: array
}
class defaultDocsProcessorConfig {
+component: undefined
+overwriteLocalCopies: boolean
+remoteReadmeVersion: string
}
deprecatedDocsProcessor -- fileConfigs : uses
deprecatedDocsProcessor -- defaultDocsProcessorConfig : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a script to remove the deprecated package from projects that use it.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
return path.join(process.cwd(), filePath); | ||
} | ||
|
||
export const fileConfigs = () => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: fileConfigs is invoked with a config parameter it doesn't accept.
The function 'fileConfigs' is defined without parameters, but later called with 'config'. Either update the function to accept and use the config parameter or remove the argument when calling it for better clarity.
Suggested implementation:
export const fileConfigs = (config) => [
If there are any calls to fileConfigs that no longer pass the config parameter, you'll want to update them accordingly to pass config if necessary.
🎉 This PR is included in version 2.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Deprecate the auro-combobox component and add a warning message to the documentation, advising users to migrate to the new Auro Formkit.
Documentation: