-
Notifications
You must be signed in to change notification settings - Fork 4
DEPRECATION: add deprecation warning to this package #305
Conversation
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request adds a deprecation warning to the auro-datepicker component and updates the documentation build process to reflect the deprecation. It introduces a new documentation processor and template specifically for deprecated components, guiding users to migrate to the new Auro Formkit. Class diagram for documentation build processclassDiagram
class deprecatedDocsProcessor {
+processDocFiles(config)
+fileConfigs()
}
class templateFiller {
+extractNames()
+formatApiTable()
}
class Logger {
+log(message)
+error(message)
}
deprecatedDocsProcessor --|> templateFiller : uses
deprecatedDocsProcessor --|> Logger : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more specific deprecation date or timeframe to the warning messages.
- It might be helpful to include migration instructions or a link to a migration guide in the deprecation warning.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
return path.join(process.cwd(), filePath); | ||
} | ||
|
||
export const fileConfigs = () => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: fileConfigs is invoked with a config parameter but does not accept any.
In processDocFiles the call is made as fileConfigs(config) though fileConfigs is defined without parameters. Consider refactoring fileConfigs to either accept the config parameter and use it, or call it without arguments to avoid confusion.
export const fileConfigs = () => [ | |
export const fileConfigs = (config) => [ |
Surge demo deployment failed! 😭 |
🎉 This PR is included in version 3.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Documentation: