-
Notifications
You must be signed in to change notification settings - Fork 1
DEPRECATION: add deprecation warning to this package #282
Conversation
As part of the new formkit release, all old form element repositories are being deprecated.
Reviewer's Guide by SourceryThis pull request adds a deprecation warning to the auro-dropdown component and updates the documentation build process to accommodate deprecated components. It also updates the CSS link in the README to point to the auro-classic CSS. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more detailed explanation of the deprecation and migration process in the README.
- It might be helpful to include the date of deprecation to give users a sense of urgency.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
// setup | ||
await templateFiller.extractNames(); | ||
|
||
for (const fileConfig of fileConfigs(config)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: The 'config' parameter is passed to fileConfigs even though fileConfigs does not accept any arguments.
Either update fileConfigs to make use of the provided config or remove the parameter when calling it in processDocFiles.
for (const fileConfig of fileConfigs(config)) { | |
for (const fileConfig of fileConfigs()) { |
🎉 This PR is included in version 3.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-formkit#394, adding deprecation warning to old form element repositories.
Summary by Sourcery
Adds a deprecation warning to the package, indicating that it is no longer supported and users should migrate to Auro Formkit. Updates the documentation and build process to reflect this change.
Enhancements:
Documentation: