-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(form): more in-depth form docs #392
base: main
Are you sure you want to change the base?
Conversation
Adds more examples and a much more in-depth explanation of form.
Reviewer's Guide by SourceryThis pull request enhances the documentation for the Updated class diagram for AuroFormStateclassDiagram
class AuroFormState {
+string hotelCity
+string[] dates
+number numberOfGuests
}
note for AuroFormState "Represents the structure of the form data collected by auro-form"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- The updated documentation provides a comprehensive guide to using the
auro-form
component, which is a significant improvement. - Consider adding a section on how to handle form validation and error messages, as this is a common requirement for forms.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Adds more examples and a much more in-depth explanation of form.
Alaska Airlines Pull Request
Resolves #391
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Updates the form documentation to include more in-depth explanations, examples, and information on how to access form data and handle custom elements.
Documentation: