-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Fix input span slotting #396
Conversation
All examples were using `<slot slot=` and this fixes it to use the proper `<span slot=`.
Reviewer's Guide by SourceryThis pull request fixes the slot syntax in the auro-input examples, replacing the incorrect Updated class diagram for auro-input componentclassDiagram
class auro-input {
-label: string
-helptext: string
+attributeChangedCallback(name: string, oldValue: any, newValue: any): void
}
note for auro-input "The slot syntax for label and helptext has been updated from <slot slot=...> to <span slot=...>"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good catch, using
span
instead ofslot
is the correct approach for named slots.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
All examples were using
<slot slot=
and this fixes it to use the proper<span slot=
.Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Corrects the usage of span slotting in the auro-input component examples, replacing
<slot slot=
with the proper<span slot=
. Also, updates the auro-formkit version in the README.